test: improve code coverage for string decoder - #22306
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16452/ ✔️ |
Sorry, something went wrong.
|
Hi, collaborators, (cc @trivikr @Trott who helped to post CI instances in previous comments) Saw some approvals & read the previous failed CI instance w. the referred issue above. I have rebased the feature branch of this PR and pushed, as an attempt to obtain a "green" CI instance. After the attempt, the current PR seems to have a "green" CI instance. Would you mind guiding this PR to "land", after the "green" CI instance has been obtained & approvals? |
Sorry, something went wrong.
|
Landed in 5673017 🎉 @BeniCheni Thanks! Usually a simple ping is enough to get things done.
By the way, it looks like you used something that creates a “merge commit” (which is what you get by default from running git pull or git merge), not a typical rebase. |
Sorry, something went wrong.
PR-URL: #22306 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Thank you for landing! Good to learn about the rebase workflow, which I'd be mindful about. |
Sorry, something went wrong.
PR-URL: #22306 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #22306 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #22306 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This PR attempts to cover this line of uncovered string decoder code from the coverage report, after exploring with nodejs/getting-started repo that led to consulting with nodetodo.org about contributing to unit test code.
Checklist