FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update wrapping-related documentation by gabrielschulhof · Pull Request #22363 · nodejs/node · GitHub

/ node Public

doc: update wrapping-related documentation - #22363

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-fix-wrap-doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: update wrapping-related documentation#22363
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-fix-wrap-doc

Conversation

gabrielschulhof commented Aug 16, 2018

Copy link
Copy Markdown
Contributor

Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 16, 2018

Copy link
Copy Markdown
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/573/pipeline

nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Aug 16, 2018
BridgeAR added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 17, 2018

BridgeAR commented Aug 17, 2018

Copy link
Copy Markdown
Member

Collaborators, please +1 if you are fine to fast track this.

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16595/

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/16597/

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Resumed again as: https://ci.nodejs.org/job/node-test-pull-request/16602/

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/16603/

doc: update wrapping-related documentation
f6ba436 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Rebased to hopefully fix CI.

New CI: https://ci.nodejs.org/job/node-test-pull-request/16607/

Re: nodejs/build#1467 (comment)

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

CI Resumed as https://ci.nodejs.org/job/node-test-pull-request/16613/

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

And another CI from the top: https://ci.nodejs.org/job/node-test-pull-request/16614/

gabrielschulhof commented Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Landed in e19aa2663149fa2770d2cdfcca3ee54447fec2b7.

gabrielschulhof deleted the n-api-fix-wrap-doc branch August 20, 2018 18:42

gabrielschulhof commented Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

sigh

Forgot to git push origin master. The new commitid is 9dae0ae.

gabrielschulhof pushed a commit that referenced this pull request Aug 21, 2018
doc: update wrapping-related documentation
9dae0ae 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Aug 24, 2018
doc: update wrapping-related documentation
83f6582 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
doc: update wrapping-related documentation
282a45d 
Update the N-API documentation to reflect that wrapping no longer
affects the object's prototype chain.

PR-URL: #22363
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
JungMinu JungMinu approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL