test: add test unknown credential error of process.setgroups - #22368
Closed
shisama wants to merge 1 commit into
Closed
test: add test unknown credential error of process.setgroups#22368shisama wants to merge 1 commit into
shisama wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BridgeAR
approved these changes
Aug 17, 2018
jasnell
approved these changes
Aug 17, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Aug 17, 2018
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, but the last CI run didn't go well (infrastructure issues).
Sorry, something went wrong.
trivikr
approved these changes
Aug 17, 2018
lpinca
approved these changes
Aug 17, 2018
Copy link
Copy Markdown
Member
|
This PR needs a rebase against master to avoid the git failure in the CI. |
Sorry, something went wrong.
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase coverage.
shisama
force-pushed
the
test-process-setgroups-error
branch
from
5f55a29 to
92c29f2
Compare
August 20, 2018 01:20
Copy link
Copy Markdown
Contributor
Author
|
@joyeecheung Thank you for your comment. I rebased this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Maybe node-test-commit-linux failure is a flaky test (#20628). 12:21:48 not ok 2287 sequential/test-http2-session-timeout 12:21:48 --- 12:21:48 duration_ms: 0.926 12:21:48 severity: fail 12:21:48 exitcode: 1 12:21:48 stack: |- 12:21:48 (node:19667) ExperimentalWarning: The http2 module is an experimental API. 12:21:48 assert.js:84 12:21:48 throw new AssertionError(obj); 12:21:48 ^ 12:21:48 12:21:48 AssertionError [ERR_ASSERTION]: function should not have been called at /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/sequential/test-http2-session-timeout.js:9 12:21:48 at Http2Server.mustNotCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1404-64/test/common/index.js:517:12) 12:21:48 at Http2Server.emit (events.js:182:13) 12:21:48 at ServerHttp2Session.sessionOnTimeout (internal/http2/core.js:2545:15) 12:21:48 at Object.onceWrapper (events.js:273:13) 12:21:48 at ServerHttp2Session.emit (events.js:182:13) 12:21:48 at ServerHttp2Session._onTimeout (internal/http2/core.js:1270:10) 12:21:48 at ontimeout (timers.js:454:11) 12:21:48 at tryOnTimeout (timers.js:326:5) 12:21:48 at listOnTimeout (timers.js:300:5) 12:21:48 at processTimers (timers.js:257:5) |
Sorry, something went wrong.
addaleax
approved these changes
Aug 23, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Aug 24, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase coverage. PR-URL: #22368 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase coverage. PR-URL: #22368 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase coverage. PR-URL: #22368 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
This was referenced Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test to check ERR_UNKNOWN_CREDENTIAL of process.setgroups to increase
coverage.
Checklist