test: move custom WHATWG URL tests into separate files - #22442
test: move custom WHATWG URL tests into separate files#22442joyeecheung wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/616/pipeline |
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16647/ cc @nodejs/url |
Sorry, something went wrong.
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation).
TimothyGu
left a comment
There was a problem hiding this comment.
Thanks! Excited to see automated WPT updates.
Sorry, something went wrong.
cjihrig
left a comment
There was a problem hiding this comment.
Mostly rubber stamp LGTM
Sorry, something went wrong.
|
Just thinking out loud: would it help to isolate wpt in test/wpt? |
Sorry, something went wrong.
I think so, yes. In either test/wpt or deps/wpt |
Sorry, something went wrong.
|
@targos For the custom tests I think it's better if they stay in parallel until they are upstreamed (otherwise it does not make sense to put tests that are not written in WPT format into a folder called wpt). For the rolled tests I think this is a good idea (although we cannot run them parallel that way, but they are not really time-consuming anyway). In my WIP branch I have tried both putting the drivers in multiple files (one parallel/test-whatwg-url-* corresponds to one upstream .any.js), and putting them in one driver that loops through a list and run time in a sandbox, it doesn't seem to make too much difference since the running time of neither is noticeable. |
Sorry, something went wrong.
|
Also for the tests downloaded from the upstream I think it makes sense to put them in test/fixtures and read them to run in a sandbox in scripts under test/wpt. It's a bit weird to put them in deps because they will not be compiled into the releases. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Restarted arm build: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3202 |
Sorry, something went wrong.
|
ARM CI is green |
Sorry, something went wrong.
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation). PR-URL: #22442 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation). PR-URL: #22442 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation). PR-URL: #22442 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
To enable automatic update of WPT, move all our custom WHATWG URL tests that are not present in the upstream into files starting with `test-whatwg-url-custom-`, so it's easier to identify test cases that can be upstreamed and test cases that should be rolled into our repo (possibly with automation). PR-URL: #22442 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
To enable automatic update of WPT, move all our custom
WHATWG URL tests that are not present in the upstream into
files starting with test-whatwg-url-custom-, so it's easier
to identify test cases that can be upstreamed and test cases
that should be rolled into our repo (possibly with automation).
I also have a WIP branch of node-core-utils for git node wpt that automatically roll the upstream into our repo (there are currently 2 any.js that fail due to dependency of other Web APIs). There are still a few pending changes to be made to run the window.js/.html tests properly.
Checklist