FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move common.ArrayStream to separate module by jasnell · Pull Request #22447 · nodejs/node · GitHub

/ node Public

test: move common.ArrayStream to separate module - #22447

Closed
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:test-no-common-arraystream
ConversationCommits (3)ChecksFiles changed
Closed

test: move common.ArrayStream to separate module#22447
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:test-no-common-arraystream

Conversation

jasnell commented Aug 21, 2018

Copy link
Copy Markdown
Member

In a continuing effort to de-monolithize require('../common'),
move common.ArrayStream out to a separate module that is
imported only when it is needed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 21, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/620/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 21, 2018
trivikr reviewed Aug 22, 2018
View reviewed changes
Comment thread test/common/README.md Outdated

trivikr Aug 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does arrayStream needs to be removed from line 41?

Trott Aug 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since that seemed self-evident, I went ahead and did it. Separate commit so if I'm wrong, it can be rebased out easily.

jasnell commented Aug 22, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16679/

jasnell added 2 commits August 22, 2018 06:42
test: move common.ArrayStream to separate module
172c628 
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.
[Squash] lint
4a82568
jasnell force-pushed the test-no-common-arraystream branch from 6ff0d5d to 4a82568 Compare August 22, 2018 13:44

jasnell commented Aug 22, 2018

Copy link
Copy Markdown
Member Author

CI failed with infrastructure and lint issues.. trying yet again: https://ci.nodejs.org/job/node-test-pull-request/16682/

jasnell commented Aug 22, 2018

Copy link
Copy Markdown
Member Author

@nodejs/build ... linuxone build bot is failing consistently again.

refack commented Aug 22, 2018

Copy link
Copy Markdown
Contributor

@nodejs/build ... linuxone build bot is failing consistently again.

Fixed - https://ci.nodejs.org/job/node-test-commit-linuxone/4284/

Trott commented Aug 23, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16706/

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 23, 2018
jasnell added a commit that referenced this pull request Aug 23, 2018
test: move common.ArrayStream to separate module
fa543c0 
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.

PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Aug 23, 2018

Copy link
Copy Markdown
Member Author

Landed in fa543c0

jasnell closed this Aug 23, 2018
targos pushed a commit that referenced this pull request Aug 24, 2018
test: move common.ArrayStream to separate module
244850d 
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.

PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
test: move common.ArrayStream to separate module
98af170 
In a continuing effort to de-monolithize `require('../common')`,
move `common.ArrayStream` out to a separate module that is
imported only when it is needed.

PR-URL: #22447
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
trivikr trivikr approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL