FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix `make format-cpp-build` by refack · Pull Request #22481 · nodejs/node · GitHub

/ node Public

tools: fix make format-cpp-build - #22481

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:fix-format-cpp-build
Closed

tools: fix make format-cpp-build#22481
refack wants to merge 1 commit into
nodejs:masterfrom
refack:fix-format-cpp-build

Conversation

refack commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

Fix a regression introduced by #22399

Please 👍 for fast tracking.

Ref: #22399 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

refack added tools Issues and PRs related to the tools directory. regression Issues related to regressions. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 23, 2018
refack requested review from addaleax and joyeecheung August 23, 2018 15:22

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 23, 2018
refack force-pushed the fix-format-cpp-build branch from 8064a1c to 21f38c7 Compare August 23, 2018 15:23
refack changed the title Fix format cpp build tools: fix make format-cpp-build Aug 23, 2018

refack commented Aug 23, 2018

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/build-files @nodejs/linting

refack commented Aug 24, 2018

Copy link
Copy Markdown
Contributor Author

Closing in favor of #22500

refack closed this Aug 24, 2018
refack deleted the fix-format-cpp-build branch August 24, 2018 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL