FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: import acorn@5.7.2 by rubys · Pull Request #22488 · nodejs/node · GitHub

/ node Public

deps: import acorn@5.7.2 - #22488

Closed
rubys wants to merge 3 commits into
nodejs:masterfrom
rubys:acorn-5.7.1
ConversationCommits (3)ChecksFiles changed
Closed

deps: import acorn@5.7.2#22488
rubys wants to merge 3 commits into
nodejs:masterfrom
rubys:acorn-5.7.1

Conversation

rubys commented Aug 23, 2018

Copy link
Copy Markdown
Member

Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

deps: import acorn@5.7.1
c67b9e2 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.1.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in nodejs#22405.

nodejs-github-bot commented Aug 23, 2018

Copy link
Copy Markdown
Collaborator

@rubys build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/652/pipeline

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 23, 2018
refack approved these changes Aug 23, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

refack commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

/CC @TimothyGu

BridgeAR approved these changes Aug 23, 2018
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

TimothyGu reviewed Aug 23, 2018
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I admittedly haven't been too diligent on upgrading Acorn… Would you mind regenerating the LICENSE.md file by running tools/license-builder.sh?

[squashme] update license
4ab713e 
update produced by tools/license-builder.sh
jdalton suggested changes Aug 23, 2018
View reviewed changes

jdalton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Holding to see if acorn can bump changes in their master so that we can upgrade to the more recent latest and greatest. (if not possible in a few days I'll release the hold)

rubys commented Aug 24, 2018

Copy link
Copy Markdown
Member Author

@jdalton "Latest commit bba80ab 17 days ago". Are you pursuing a release or there something I should be doing to make this happen?

jdalton commented Aug 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@rubys Just a release. Nothing you need to do (beside bump the acorn dep in the PR when appropriate). Their last release was mid June so if they are able to bump then we'll get more fresh bits is all.

rubys commented Aug 24, 2018

Copy link
Copy Markdown
Member Author

@jdaldon, let me rephrase the question. Are you aware of the acorn team actively preparing a release, or has somebody asked them to produce a release, or are we merely delaying on the off chance that a release coincidentally happens in the next few days?

jdalton commented Aug 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@rubys

Are you aware of the acorn team actively preparing a release, or has somebody asked them to produce a release

Yes, I've inquired about a release.

rubys commented Aug 24, 2018

Copy link
Copy Markdown
Member Author

@jdalton done. Thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/16719/

rubys changed the title deps: import acorn@5.7.1 deps: import acorn@5.7.2 Aug 24, 2018
refack approved these changes Aug 24, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still RSLGTM

refack commented Aug 25, 2018

Copy link
Copy Markdown
Contributor

Resume CI: https://ci.nodejs.org/job/node-test-commit/20908/

rubys commented Aug 26, 2018

Copy link
Copy Markdown
Member Author

Failures: https://ci.nodejs.org/job/node-test-binary-windows/19527/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

17:23:33 ERROR: Error fetching remote repo 'jenkins_tmp'
17:23:33 hudson.plugins.git.GitException: Failed to fetch from binary_tmp@147.75.70.237:binary_tmp.git
17:23:33 stderr: fatal: Unable to create 'c:/workspace/node-test-binary-windows/.git/index.lock': File exists.
17:23:33 
17:23:33 Another git process seems to be running in this repository, e.g.
17:23:33 an editor opened by 'git commit'.

trivikr approved these changes Aug 26, 2018
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

rubys added a commit to rubys/node that referenced this pull request Aug 26, 2018
deps: import acorn@5.7.2
49bfc37 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in nodejs#22405.

PR-URL: nodejs#22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

rubys commented Aug 26, 2018

Copy link
Copy Markdown
Member Author

landed: 49bfc37

rubys closed this Aug 26, 2018
addaleax pushed a commit that referenced this pull request Aug 27, 2018
deps: import acorn@5.7.2
d47e342 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
deps: import acorn@5.7.2
aa22dc8 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
deps: import acorn@5.7.2
6405ad9 
Imported from the tarball published on npm
(https://registry.npmjs.org/acorn/-/acorn-5.7.2.tgz).

Update to emcaScript version 10 in order to get support for
binding-less catch statements.

Also needed to parse node.js lib API in #22405.

PR-URL: #22488
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+3 more reviewers
jdalton jdalton approved these changes
refack refack approved these changes
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL