FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify fallback behavior of module require by TomCoded · Pull Request #22494 · nodejs/node · GitHub

/ node Public

doc: clarify fallback behavior of module require - #22494

Closed
TomCoded wants to merge 1 commit into
nodejs:masterfrom
TomCoded:i22464
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify fallback behavior of module require#22494
TomCoded wants to merge 1 commit into
nodejs:masterfrom
TomCoded:i22464

Conversation

TomCoded commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

fixes: #22464

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Aug 24, 2018

vsemozhetbyt commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/657/

vsemozhetbyt commented Aug 26, 2018

Copy link
Copy Markdown
Contributor

I am not sure if this is an appropriate team, correct me if I am wrong: cc @nodejs/modules

TomCoded commented Aug 26, 2018

Copy link
Copy Markdown
Contributor Author

See new discussion at #22464 re: whether the documented behavior is a bug.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 27, 2018

addaleax commented Aug 27, 2018

Copy link
Copy Markdown
Member

I think this is ready apart from the fact that it’s not 100 % clear to me that it fully resolves #22464. But if there are no objections in the near future, I’ll go ahead and merge this as-is (i.e. with the Fixes: tag).

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member

Landed in 594dd42, thanks for the PR!

addaleax closed this Sep 2, 2018
addaleax pushed a commit that referenced this pull request Sep 2, 2018
doc: clarify fallback behavior of module require
594dd42 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
doc: clarify fallback behavior of module require
17bc49e 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
doc: clarify fallback behavior of module require
7d8ef42 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
doc: clarify fallback behavior of module require
f0208b3 
PR-URL: #22494
Fixes: #22464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+1 more reviewer
gdams gdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Folders as Modules docs: Inaccuracy regarding missing main file?

5 participants

Back | FazBrowse Home | New Git URL