FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor structure of common/index by jasnell · Pull Request #22511 · nodejs/node · GitHub

/ node Public

test: refactor structure of common/index - #22511

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:test-refactor-index
ConversationCommits (1)ChecksFiles changed
Closed

test: refactor structure of common/index#22511
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:test-refactor-index

Conversation

jasnell commented Aug 24, 2018

Copy link
Copy Markdown
Member

Further work on restructuring common/index.js. This updates to the module.exports = {} structure so that it's easier to see what exactly is being exported. Part of an ongoing effort to incrementally de-monolith-ize the thing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 24, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/665/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 24, 2018

jasnell commented Aug 24, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16738/

Trott commented Aug 24, 2018

Copy link
Copy Markdown
Member

@nodejs/testing

lpinca approved these changes Aug 25, 2018
View reviewed changes
Comment thread test/common/index.js Outdated

lpinca Aug 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: s/exports/this/

refack reviewed Aug 25, 2018
View reviewed changes
Comment thread test/common/index.js Outdated

refack Aug 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Suggestion, use IIFE:

const PIPE = (() => {
  const localRelative = path.relative(process.cwd(), `${tmpdir.path}/`);
  const pipePrefix = isWindows ? '\\\\.\\pipe\\' : localRelative;
  const pipeName = `node-test.${process.pid}.sock`;
  return path.join(pipePrefix, pipeName);
})()

refack approved these changes Aug 25, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

😍

refack commented Aug 25, 2018

Copy link
Copy Markdown
Contributor

+10 for readability, and style conformance.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 27, 2018
jasnell force-pushed the test-refactor-index branch from 3c7b47f to a38522d Compare August 27, 2018 21:15
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 27, 2018

addaleax commented Aug 27, 2018

Copy link
Copy Markdown
Member

@jasnell This needs a rebase, sorry :/

BridgeAR commented Sep 5, 2018

Copy link
Copy Markdown
Member

Ping @jasnell

jasnell commented Sep 5, 2018

Copy link
Copy Markdown
Member Author

Haven't forgotten. I've just been moving ;-) ... will be finishing this up today.

jasnell force-pushed the test-refactor-index branch from e82face to dca6d29 Compare September 5, 2018 18:25

jasnell commented Sep 5, 2018

Copy link
Copy Markdown
Member Author

CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/17033/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 5, 2018
jasnell assigned andrasq and unassigned andrasq Sep 5, 2018
jasnell added a commit that referenced this pull request Sep 5, 2018
test: refactor structure of common/index
286ca2c 
PR-URL: #22511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jasnell commented Sep 5, 2018

Copy link
Copy Markdown
Member Author

Landed in 286ca2c

jasnell closed this Sep 5, 2018
targos pushed a commit that referenced this pull request Sep 12, 2018
test: refactor structure of common/index
cf61a04 
PR-URL: #22511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
test: refactor structure of common/index
94b662a 
PR-URL: #22511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 20, 2018
test: refactor structure of common/index
b1d667b 
PR-URL: #22511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL