FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: do not lint fixtures in make lint-md by joyeecheung · Pull Request #22549 · nodejs/node · GitHub

/ node Public

build: do not lint fixtures in make lint-md - #22549

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:lint-skip-fixtures
ConversationCommits (1)ChecksFiles changed
Closed

build: do not lint fixtures in make lint-md#22549
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:lint-skip-fixtures

Conversation

joyeecheung commented Aug 27, 2018

Copy link
Copy Markdown
Member

This is useful if we need to put markdown files in test/fixtures (I was working on pulling the WPT there)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 27, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/694/pipeline

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 27, 2018

Trott commented Aug 28, 2018

Copy link
Copy Markdown
Member

I would prefer no changes to line 1093 and adding -not -path 'test/fixtures/*' to line 1096.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 31, 2018
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 2, 2018

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member

Removing author-ready because I kinda think addressing @Trott’s comment is worth it and this isn’t really all that urgent (I think)

BridgeAR commented Sep 5, 2018

Copy link
Copy Markdown
Member

Ping @joyeecheung

joyeecheung commented Sep 15, 2018

Copy link
Copy Markdown
Member Author

Updated to use the -not option instead.

CI: https://ci.nodejs.org/job/node-test-pull-request/17205/

Trott commented Sep 15, 2018 •
edited by refack
Loading

Copy link
Copy Markdown
Member

Everything is good on CI except a known Windows flake. Windows re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20733/ (Update: ✔️)

refack added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 15, 2018

refack commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

Resume CI (with a special Windows trick): https://ci.nodejs.org/job/node-test-commit/21481/

joyeecheung commented Sep 16, 2018

Copy link
Copy Markdown
Member Author

Windows is still pretty red..

refack commented Sep 16, 2018

Copy link
Copy Markdown
Contributor

So again: https://ci.nodejs.org/job/node-test-pull-request/17219/

Trott commented Sep 17, 2018

Copy link
Copy Markdown
Member

Only red was Windows fanned. Known flaky. Here's a re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20753/

addaleax commented Sep 17, 2018

Copy link
Copy Markdown
Member

… and again: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20782/

joyeecheung commented Sep 17, 2018

Copy link
Copy Markdown
Member Author

Windows build is (finally) green

joyeecheung commented Sep 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in bb9d788, thanks!

joyeecheung added a commit that referenced this pull request Sep 17, 2018
build: do not lint fixtures in make lint-md
bb9d788 
PR-URL: #22549
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 18, 2018
build: do not lint fixtures in make lint-md
6f99252 
PR-URL: #22549
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
build: do not lint fixtures in make lint-md
e07e573 
PR-URL: #22549
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
build: do not lint fixtures in make lint-md
3fcd54f 
PR-URL: #22549
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
refack refack approved these changes
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL