FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add `NODE_EXTERN` to class definition by addaleax · Pull Request #22559 · nodejs/node · GitHub

/ node Public

src: add NODE_EXTERN to class definition - #22559

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:node-extern-mip
ConversationCommits (1)ChecksFiles changed
Closed

src: add NODE_EXTERN to class definition#22559
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:node-extern-mip

Conversation

addaleax commented Aug 27, 2018

Copy link
Copy Markdown
Member

This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

src: add NODE_EXTERN to class definition
0097a86 
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.
addaleax added windows Issues and PRs related to the Windows platform. embedding Issues and PRs related to embedding Node.js in another project. labels Aug 27, 2018

nodejs-github-bot commented Aug 27, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/709/pipeline

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 27, 2018
addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 27, 2018

addaleax commented Aug 27, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16813/

Feel free to 👍 this comment to approve fast-tracking.

addaleax commented Aug 28, 2018

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16821/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 31, 2018

addaleax commented Sep 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16941/
New CI: https://ci.nodejs.org/job/node-test-pull-request/16958/

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member Author

Landed in 04060e3

addaleax closed this Sep 2, 2018
addaleax deleted the node-extern-mip branch September 2, 2018 22:26
addaleax added a commit that referenced this pull request Sep 2, 2018
src: add NODE_EXTERN to class definition
04060e3 
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.

PR-URL: #22559
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
src: add NODE_EXTERN to class definition
cfca851 
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.

PR-URL: #22559
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
src: add NODE_EXTERN to class definition
caaeceb 
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.

PR-URL: #22559
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed

nodejs-github-bot commented Apr 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22560/

addaleax commented Apr 19, 2019

Copy link
Copy Markdown
Member Author

@joyeecheung You started the CI run above, but I guess it was meant for a different PR? 😄

joyeecheung commented Apr 19, 2019

Copy link
Copy Markdown
Member

Um I probably copy-pasted the wrong number, sorry!

addaleax added the v8 platform Issues and PRs related to Node's v8::Platform implementation. label Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
+1 more reviewer
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. fast-track PRs that do not need to wait for 48 hours to land. v8 platform Issues and PRs related to Node's v8::Platform implementation. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL