FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

win,build: build N-API addons in parallel by bzoz · Pull Request #22582 · nodejs/node · GitHub

/ node Public

win,build: build N-API addons in parallel - #22582

Closed
bzoz wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:bartek-napi-parallel
ConversationCommits (1)ChecksFiles changed
Closed

win,build: build N-API addons in parallel#22582
bzoz wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:bartek-napi-parallel

Conversation

bzoz commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

Similar to #21403, build N-API modules in parallel.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 29, 2018

Copy link
Copy Markdown
Collaborator

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/722/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Aug 29, 2018

bzoz commented Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16859/

refack approved these changes Aug 29, 2018
View reviewed changes
Comment thread vcbuild.bat
"%node_exe%" "%~dp0tools\build-addons.js" "%~dp0deps\npm\node_modules\node-gyp\bin\node-gyp.js" "%~dp0test\addons-napi"
if errorlevel 1 exit /b 1
endlocal
endlocal

refack Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you remove this extra endlocal.
Any idea what this mathes? My guess it's probably left over from something old c403eeb

bzoz Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TBH, I don't know. It's there, I don't want to break anything. Another PR maybe?

refack Aug 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

NP.

refack Aug 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ping me when you land this.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 31, 2018

addaleax commented Aug 31, 2018

Copy link
Copy Markdown
Member

Landed in c57ed41

@refack ping :)

addaleax closed this Aug 31, 2018
addaleax pushed a commit that referenced this pull request Aug 31, 2018
win,build: build N-API addons in parallel
c57ed41 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack mentioned this pull request Aug 31, 2018
Merged
2 tasks

refack commented Aug 31, 2018

Copy link
Copy Markdown
Contributor

@refack ping :)

Thanks. Following up in #22627

addaleax pushed a commit that referenced this pull request Aug 31, 2018
win,build: build N-API addons in parallel
b687c29 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 3, 2018
win,build: build N-API addons in parallel
041c779 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
win,build: build N-API addons in parallel
fbf34d0 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL