doc: add profiling APIs to the diagnostics support document - #22588
Closed
mmarchini wants to merge 2 commits into
Closed
doc: add profiling APIs to the diagnostics support document#22588mmarchini wants to merge 2 commits into
mmarchini wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job.
Copy link
Copy Markdown
Collaborator
|
@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/725/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
cc @nodejs/diagnostics |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Do you have some documentation for --interpreted-frames-native-stack? I would like to know more. |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Aug 30, 2018
mcollina
reviewed
Aug 30, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you please edit only the specific lines? It’s very hard to review otherwise.
Sorry, something went wrong.
mmarchini
force-pushed
the
perf-diagnostic-tools-update
branch
from
fc0062d to
c1ab6f1
Compare
August 30, 2018 11:36
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs.
mmarchini
force-pushed
the
perf-diagnostic-tools-update
branch
from
c1ab6f1 to
eb4fe44
Compare
August 30, 2018 11:39
Copy link
Copy Markdown
Contributor
Author
|
@mcollina done! (I was trying to keep the table aligned) @AndreasMadsen from --v8-options: --interpreted-frames-native-stack (Show interpreted frames on the native stack (useful for external profilers).)
type: bool default: false
There flag is also mentioned in mmarchini/nodejs-production-diagnostic-tools and I'm writing blog posts to document how to use this flag with Linux perf, DTrace and similar tools. |
Sorry, something went wrong.
mcollina
approved these changes
Aug 30, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
+1 on keeping the table aligned, but maybe in a separate commit so it's easy to see the difference. |
Sorry, something went wrong.
cjihrig
approved these changes
Aug 30, 2018
BridgeAR
approved these changes
Aug 30, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
We have tests for Linux perf under `test/v8-updates/test-linux-perf.js`, and those tests are run as part of the `node-test-commit-v8-linux` job. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Add V8 CodeEventHandler and --interpreted-frames-native-stack to our diagnostics tiers of support document as Unclassified APIs. PR-URL: #22588 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit updates Linux perf "Regular Testing in Node.js CI" to Yes since we have tests for Linux perf in our CI (as part of the node-test-commit-v8-linux job). The second commit adds V8's CodeEventHandler API and the --interpreted-frames-native-stack flag as "Not yet classified" tools/APIs, since the flag is essential for system profiling tools to correctly sample Node.js processes and the API is useful to avoid using --perf-basic-prof.
Checklist