tools: add [src] links to assert.html - #22601
Conversation
Sorry, something went wrong.
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`.
|
@rubys build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/733/pipeline |
Sorry, something went wrong.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "asserts.ok": "reverse.js#L10" | |||
There was a problem hiding this comment.
Any chance we could figure out that this should link to L5? (It seems too tricky to me but I figured I’d ask 🙂)
Sorry, something went wrong.
There was a problem hiding this comment.
I'll take a look. I'm inclined to only do that for statements of the form:
x.y = y;
In other words, not for the following (which would be an alias):
x.y = z;
Thoughts?
Sorry, something went wrong.
There was a problem hiding this comment.
I think that sounds reasonable, yeah :)
Sorry, something went wrong.
Hard to explain, see test case for examples. :-)
Sorry, something went wrong.
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: nodejs#22601 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Parse const assert = module.exports = ok; as exporting a constructor
named assert.
Checklist