FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove editing leftovers from options help text by addaleax · Pull Request #22636 · nodejs/node · GitHub

/ node Public

src: remove editing leftovers from options help text - #22636

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:remove-2u
Closed

src: remove editing leftovers from options help text#22636
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:remove-2u

Conversation

Copy link
Copy Markdown
Member

Refs: 85212bb#r30265305

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 31, 2018
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 1, 2018

BridgeAR commented Sep 1, 2018
edited by addaleax
Loading

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/16918/ (:heavy_check_mark:)

danbev commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Landed in 65f0323.

danbev closed this Sep 5, 2018
danbev pushed a commit that referenced this pull request Sep 5, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax deleted the remove-2u branch September 5, 2018 09:24
targos pushed a commit that referenced this pull request Sep 5, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL