Update v8.md - #22639
Closed
lakamsani wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
requested changes
Aug 31, 2018
Comment thread
doc/api/v8.md
Outdated
moved changed to L420 and url to https://v8docs.nodesource.com/node-10.6/d5/dda/classv8_1_1_isolate.html#ac673576f24fdc7a33378f8f57e1d13a4 per review from @richardlau
richardlau
approved these changes
Sep 1, 2018
vsemozhetbyt
approved these changes
Sep 1, 2018
Copy link
Copy Markdown
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ChALkeR
approved these changes
Sep 1, 2018
Copy link
Copy Markdown
Member
|
The actual change LGTM, but I have a pair of questions: |
Sorry, something went wrong.
BridgeAR
approved these changes
Sep 1, 2018
Copy link
Copy Markdown
Contributor
Author
|
@ChALkeR I found this manually. |
Sorry, something went wrong.
lpinca
approved these changes
Sep 1, 2018
vsemozhetbyt
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22639 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22639 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22639 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc: fixed broken link to GetHeapSpaceStatistics
here is the broken link: https://nodejs.org/api/v8.html#v8_v8_getheapspacestatistics