FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update to nghttp2 1.33.0 by addaleax · Pull Request #22649 · nodejs/node · GitHub

/ node Public

deps: update to nghttp2 1.33.0 - #22649

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:nghttp2-1.33.0
ConversationCommits (2)ChecksFiles changed
Closed

deps: update to nghttp2 1.33.0#22649
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:nghttp2-1.33.0

Conversation

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member

Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

addaleax added the http2 Issues or PRs related to the http2 subsystem. label Sep 2, 2018

nodejs-github-bot commented Sep 2, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/765/pipeline

nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 2, 2018

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16934/

targos commented Sep 2, 2018

Copy link
Copy Markdown
Member

@nodejs/http2

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/16936/

cjihrig approved these changes Sep 2, 2018
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a question.

Comment thread deps/nghttp2/lib/includes/nghttp2/nghttp2ver.h Outdated
* Version number of the nghttp2 library release
*/
#define NGHTTP2_VERSION "1.32.0"
#define NGHTTP2_VERSION "1.33.0-DEV"

cjihrig Sep 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we be moving to a dev version? Or is this maybe a mistake on their end (based on the linked GitHub release)?

addaleax Sep 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is a mistake by me, not having run configure in the nghttp2 checkout before copying the files. Thanks for catching!

mcollina approved these changes Sep 2, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubberstamp LGTM

trivikr approved these changes Sep 4, 2018
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

danbev commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Landed in e007166.

danbev closed this Sep 5, 2018
danbev pushed a commit that referenced this pull request Sep 5, 2018
deps: update to nghttp2 1.33.0
e007166 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 5, 2018
deps: update to nghttp2 1.33.0
2c33dc3 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
deps: update to nghttp2 1.33.0
6f14b96 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
deps: update to nghttp2 1.33.0
8605837 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
deps: update to nghttp2 1.33.0
f6d9bf3 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
deps: update to nghttp2 1.33.0
60f7bfa 
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

Backport-PR-URL: #22850
PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Oct 30, 2018
Merged
beevelop mentioned this pull request Nov 20, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
cjihrig cjihrig approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL