http2: don't expose the original socket through the socket proxy - #22650
Closed
szmarczak wants to merge 1 commit into
Closed
http2: don't expose the original socket through the socket proxy#22650szmarczak wants to merge 1 commit into
szmarczak wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
mcollina
approved these changes
Sep 3, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Good work on your first contribution @szmarczak! CI: https://ci.nodejs.org/job/node-test-pull-request/16980/ (:heavy_check_mark:) |
Sorry, something went wrong.
lpinca
approved these changes
Sep 3, 2018
apapirovski
suggested changes
Sep 4, 2018
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for doing this!! Edit: ugh... mobile UI...
Sorry, something went wrong.
apapirovski
approved these changes
Sep 4, 2018
Copy link
Copy Markdown
Member
Author
Indeed, mobile UI doesn't look good :P |
Sorry, something went wrong.
jasnell
approved these changes
Sep 4, 2018
This was referenced Sep 6, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 3, 2018
Refs: nodejs#22486 PR-URL: nodejs#22650 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Refs: nodejs#22486 PR-URL: nodejs#22650 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions expose the original socket:
To avoid that, forward session.socket.ref to session.ref, session.socket.unref to session.unref and throw ERR_HTTP2_NO_SOCKET_MANIPULATION when accessing setEncoding, setKeepAlive or setNoDelay.
Refs: #22486
Checklist