FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky async-hooks/test-callback-error by addaleax · Pull Request #22655 · nodejs/node · GitHub

/ node Public

test: fix flaky async-hooks/test-callback-error - #22655

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:flaky-callback-error
ConversationCommits (3)ChecksFiles changed
Closed

test: fix flaky async-hooks/test-callback-error #22655
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:flaky-callback-error

Conversation

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Sep 2, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/769/pipeline

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Sep 2, 2018

addaleax commented Sep 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16946/
CI: https://ci.nodejs.org/job/node-test-pull-request/16949/

Please 👍 this comment to allow fast-tracking.

addaleax added fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Sep 2, 2018
addaleax mentioned this pull request Sep 2, 2018
Closed
addaleax force-pushed the flaky-callback-error branch from f95be6c to 5d66adb Compare September 2, 2018 13:53
lundibundi reviewed Sep 2, 2018
View reviewed changes

lundibundi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps this comment is also obsolete now https://github.com/nodejs/node/pull/22655/files#diff-0cc0d48d1f2c9d1e273bc03e7f9a0c9bR61 ?

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member Author

@lundibundi Thanks, done!

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 4, 2018

addaleax commented Sep 5, 2018

Copy link
Copy Markdown
Member Author

Landed in 67bfcb7, 702e114

addaleax closed this Sep 5, 2018
addaleax deleted the flaky-callback-error branch September 5, 2018 10:40
addaleax added a commit that referenced this pull request Sep 5, 2018
test: fix flaky async-hooks/test-callback-error
67bfcb7 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Sep 5, 2018
Revert "test: mark async-hooks/test-callback-error as flaky"
702e114 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 5, 2018
test: fix flaky async-hooks/test-callback-error
4791cd7 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 5, 2018
Revert "test: mark async-hooks/test-callback-error as flaky"
7a3bbd2 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
test: fix flaky async-hooks/test-callback-error
8792609 
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2018
Revert "test: mark async-hooks/test-callback-error as flaky"
d626372 
This reverts commit 59c8abf.

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
lundibundi lundibundi approved these changes
gdams gdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL