FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add [src] links to child-process.html by rubys · Pull Request #22706 · nodejs/node · GitHub

/ node Public

tools: add [src] links to child-process.html - #22706

Closed
rubys wants to merge 1 commit into
nodejs:masterfrom
rubys:cp-src-links
Closed

tools: add [src] links to child-process.html#22706
rubys wants to merge 1 commit into
nodejs:masterfrom
rubys:cp-src-links

Conversation

rubys commented Sep 5, 2018

Copy link
Copy Markdown
Member

handle exports. as an alternative to module.exports

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

handle exports. as an alternative to module.exports
nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 5, 2018

Copy link
Copy Markdown
Collaborator

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 5, 2018

rubys commented Sep 8, 2018

Copy link
Copy Markdown
Member Author

rubys commented Sep 8, 2018

Copy link
Copy Markdown
Member Author

Landed in 8737683

rubys closed this Sep 8, 2018
rubys added a commit to rubys/node that referenced this pull request Sep 8, 2018
handle exports. as an alternative to module.exports

PR-URL: nodejs#22706
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 9, 2018
handle exports. as an alternative to module.exports

PR-URL: #22706
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL