FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update eslint to v5.5.0 by BridgeAR · Pull Request #22720 · nodejs/node · GitHub

/ node Public

tools: update eslint to v5.5.0 - #22720

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:update-eslint
ConversationCommits (2)ChecksFiles changed
Closed

tools: update eslint to v5.5.0#22720
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:update-eslint

Conversation

BridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
Member

Update eslint from 5.4.0 to 5.5.0. The changeset is mainly deletions due to updating a couple dependencies.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Sep 6, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/809/pipeline

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 6, 2018
trivikr approved these changes Sep 6, 2018
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

jasnell approved these changes Sep 6, 2018
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

silverwind commented Sep 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Such a big diff again 😟. I wonder if we should attempt to bundle our dependencies like eslint to a single file using webpack, similar to how yarn does it for their releases. cc: @nodejs/linting

BridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
Member Author

Since eslint is not platform specific it should not be required to run a full CI.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 6, 2018

BridgeAR commented Sep 6, 2018

Copy link
Copy Markdown
Member Author

Bundling would be a good way. If I remember correct @refack wanted to address this with rollup.

Trott commented Sep 6, 2018

Copy link
Copy Markdown
Member

tools/node_modules/eslint/node_modules/esprima/ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

Other than that one thing, I get no diff when I update ESLint, so I'm 👍 on this, but please delete that one ChangeLog file.

Trott commented Sep 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Such a big diff again 😟.

Yeah, that's why I decided not to open a PR when ESLint 5.5.0 came out. No new features that we're likely to use, and a big diff. (But that's not an objection from me! I'm OK with keeping it up to date just for the sake of having smaller diffs, even if some of them end up being disappointingly large anyway.)

silverwind commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

ChangeLog is included in this but it should have been deleted by dmn. Any idea what's up with that?

dnm only seems to search for Changelog, not ChangeLog, and its glob matching is performed case-sensitively. Suggesting to either change it to match insensitively or include ChangeLog.

silverwind commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

@Trott inikulin/dmn#12

BridgeAR commented Sep 8, 2018

Copy link
Copy Markdown
Member Author

I just ran dmn@2 on this update and pushed the now deleted files in an extra commit.

BridgeAR commented Sep 9, 2018

Copy link
Copy Markdown
Member Author

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/845/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 11, 2018
tools: update eslint to v5.5.0
623dcb7 
PR-URL: nodejs#22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

BridgeAR commented Sep 11, 2018

Copy link
Copy Markdown
Member Author

Landed in 623dcb7 🎉

BridgeAR closed this Sep 11, 2018
targos pushed a commit that referenced this pull request Sep 11, 2018
tools: update eslint to v5.5.0
62d7304 
PR-URL: #22720
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
targos mentioned this pull request Sep 18, 2018
Merged
refack mentioned this pull request Apr 25, 2019
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
trivikr trivikr approved these changes
+1 more reviewer
silverwind silverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL