FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve asymmetric crypto docs by addaleax · Pull Request #22820 · nodejs/node · GitHub

/ node Public

doc: improve asymmetric crypto docs - #22820

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-public-private
ConversationCommits (1)ChecksFiles changed
Closed

doc: improve asymmetric crypto docs#22820
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:doc-public-private

Conversation

addaleax commented Sep 12, 2018

Copy link
Copy Markdown
Member

Refs: #22792

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs/crypto

addaleax requested a review from tniessen September 12, 2018 13:27
nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 12, 2018

nodejs-github-bot commented Sep 12, 2018

Copy link
Copy Markdown
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

addaleax commented Sep 13, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/876/pipeline

addaleax commented Sep 17, 2018

Copy link
Copy Markdown
Member Author

Landed in c33e27d

addaleax closed this Sep 17, 2018
addaleax deleted the doc-public-private branch September 17, 2018 15:20
addaleax added a commit that referenced this pull request Sep 17, 2018
doc: improve asymmetric crypto docs
c33e27d 
Refs: #22792

PR-URL: #22820
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 18, 2018
doc: improve asymmetric crypto docs
41fa976 
Refs: #22792

PR-URL: #22820
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
doc: improve asymmetric crypto docs
56b17d2 
Refs: #22792

PR-URL: #22820
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
doc: improve asymmetric crypto docs
5c5d881 
Refs: #22792

PR-URL: #22820
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL