FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve test-gc-http-client-onerror by lundibundi · Pull Request #23196 · nodejs/node · GitHub

/ node Public

test: improve test-gc-http-client-onerror - #23196

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:improve-gc-http-onerror
ConversationCommits (1)ChecksFiles changed
Closed

test: improve test-gc-http-client-onerror#23196
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:improve-gc-http-onerror

Conversation

lundibundi commented Oct 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Member
  • refactor out usage of 'function' for scoping
  • inline runTest function
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

lundibundi self-assigned this Oct 1, 2018

nodejs-github-bot commented Oct 1, 2018 •
edited by lundibundi
Loading

Copy link
Copy Markdown
Collaborator

@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1085/pipeline

CI: https://ci.nodejs.org/job/node-test-pull-request/17556/

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 1, 2018
joyeecheung mentioned this pull request Oct 2, 2018
Closed

addaleax commented Oct 4, 2018

Copy link
Copy Markdown
Member

decrease amount of requests 500 -> 300

I think that might help with masking a real problem, see nodejs/reliability#18 (comment).

test: improve test-gc-http-client-onerror
acddd91 
* refactor out usage of 'function' for scoping
* inline runTest function
lundibundi force-pushed the improve-gc-http-onerror branch from 330c8e3 to acddd91 Compare October 8, 2018 22:55

lundibundi commented Oct 8, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17691/

lundibundi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 8, 2018

addaleax commented Oct 12, 2018

Copy link
Copy Markdown
Member

Landed in 0ea804a

addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
test: improve test-gc-http-client-onerror
0ea804a 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit that referenced this pull request Oct 13, 2018
test: improve test-gc-http-client-onerror
0d7328d 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 13, 2018
test: improve test-gc-http-client-onerror
e402b22 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
test: improve test-gc-http-client-onerror
939a27e 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
test: improve test-gc-http-client-onerror
21c3822 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: improve test-gc-http-client-onerror
07c103d 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: improve test-gc-http-client-onerror
8d091c2 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes

Assignees

lundibundi

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL