src: remove unused limits header from util-inl.h - #23353
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed.
Copy link
Copy Markdown
Collaborator
|
@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1179/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
cjihrig
approved these changes
Oct 9, 2018
thefourtheye
approved these changes
Oct 9, 2018
richardlau
approved these changes
Oct 9, 2018
jasnell
approved these changes
Oct 9, 2018
addaleax
approved these changes
Oct 9, 2018
Copy link
Copy Markdown
Contributor
Author
|
Re-run of failing node-test-commit-linux-containered ✔️ |
Sorry, something went wrong.
danbev
added a commit
that referenced
this pull request
Oct 12, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Oct 12, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: #23353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the inclusion of limits.h which was introduced in
commit e812be4 ("src: make CLI options
programatically accesible"), but as far as I can see it was not used
there either so it look like it can safely be removed.
Checklist