FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: make Travis commit linting more robust by Trott · Pull Request #23397 · nodejs/node · GitHub

/ node Public

tools: make Travis commit linting more robust - #23397

Closed
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:travis-commit-range
Closed

tools: make Travis commit linting more robust#23397
Trott wants to merge 3 commits into
nodejs:masterfrom
Trott:travis-commit-range

Conversation

Trott commented Oct 10, 2018
edited
Loading

Copy link
Copy Markdown
Member

Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: nodejs#23307 (comment)
Trott added the wip Issues and PRs that are still a work in progress. label Oct 10, 2018

Copy link
Copy Markdown
Collaborator

Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed wip Issues and PRs that are still a work in progress. labels Oct 10, 2018

Trott commented Oct 10, 2018

Copy link
Copy Markdown
Member Author

Looks ready-to-go. Light CI should be sufficient. 👍 here to fast-track.

Trott added the tools Issues and PRs related to the tools directory. label Oct 10, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: nodejs#23307 (comment)

PR-URL: nodejs#23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Trott commented Oct 10, 2018

Copy link
Copy Markdown
Member Author

Landed in a1edecc

Trott closed this Oct 10, 2018
targos pushed a commit that referenced this pull request Oct 10, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some
situations.

Refs: #23307 (comment)

PR-URL: #23397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs mentioned this pull request Dec 4, 2018
Trott deleted the travis-commit-range branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL