FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: move more deprecations to V8_DEPRECATED by addaleax · Pull Request #23414 · nodejs/node · GitHub

/ node Public

deps: move more deprecations to V8_DEPRECATED - #23414

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:v8-dep-again
ConversationCommits (1)ChecksFiles changed
Closed

deps: move more deprecations to V8_DEPRECATED#23414
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:v8-dep-again

Conversation

addaleax commented Oct 10, 2018

Copy link
Copy Markdown
Member

These APIs have been deprecated upstream in V8.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 10, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1195/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Oct 10, 2018
addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 10, 2018

refack commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

Is it really more efficient to keep floating patches when we can turn on V8_IMMINENT_DEPRECATION_WARNINGS?

 common.gypi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/common.gypi b/common.gypi
index 4c43db48f3..564ec316a8 100644
--- a/common.gypi
+++ b/common.gypi
@@ -264,6 +264,10 @@
         }
       }
     },
+    'defines': [
+      'V8_DEPRECATION_WARNINGS',
+      'V8_IMMINENT_DEPRECATION_WARNINGS',
+    ],
     # Forcibly disable -Werror.  We support a wide range of compilers, it's
     # simply not feasible to squelch all warnings, never mind that the
     # libraries in deps/ are not under our control.

addaleax commented Oct 11, 2018

Copy link
Copy Markdown
Member Author

@refack How much compiler warning output would we currently get with those settings?

refack commented Oct 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just from /src/ (trimming duplicates)

Number Method
3 v8::Date::New #23288
2 v8::Function::Call
29 v8::Object::Get
1 v8::Object::GetPropertyNames
147 v8::Object::Set
2 v8::String::NewFromTwoByte
2 v8::Value::ToObject
(2) v8::WasmCompiledModule::CallerOwnedBuffer

We can also consider setting it only for the "SDK" (i.e. common.gypi to be used by native addons).

This was referenced Oct 11, 2018
Closed
Merged
RomainLanz mentioned this pull request Oct 21, 2018
Merged
2 tasks
refack pushed a commit to RomainForks/node that referenced this pull request Oct 23, 2018
src: refactor deprecated v8::Function::Call call
341006b 
Refs: nodejs#23414 (comment)

PR-URL: nodejs#23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
deps: move more deprecations to V8_DEPRECATED
f12d0af 
These APIs have been deprecated upstream in V8.

addaleax commented Oct 24, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18107/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 24, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
src: refactor deprecated v8::Function::Call call
df05ddf 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

Landed in 4fe0bb3

addaleax closed this Oct 25, 2018
addaleax deleted the v8-dep-again branch October 25, 2018 18:22
addaleax added a commit that referenced this pull request Oct 25, 2018
deps: move more deprecations to V8_DEPRECATED
4fe0bb3 
These APIs have been deprecated upstream in V8.

PR-URL: #23414
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 26, 2018
deps: move more deprecations to V8_DEPRECATED
a85d5b4 
These APIs have been deprecated upstream in V8.

PR-URL: #23414
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Oct 27, 2018
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
deps: move more deprecations to V8_DEPRECATED
9011db4 
These APIs have been deprecated upstream in V8.

PR-URL: #23414
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
src: refactor deprecated v8::Function::Call call
2e3e68a 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
src: refactor deprecated v8::Function::Call call
bf4c798 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
src: refactor deprecated v8::Function::Call call
17db407 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL