FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: updating assertion and expect order in test-tls-client-verify.js by eitah · Pull Request #23547 · nodejs/node · GitHub

/ node Public

test: updating assertion and expect order in test-tls-client-verify.js - #23547

Closed
eitah wants to merge 1 commit into
nodejs:masterfrom
eitah:tls-client-verify-tests
ConversationCommits (1)ChecksFiles changed
Closed

test: updating assertion and expect order in test-tls-client-verify.js#23547
eitah wants to merge 1 commit into
nodejs:masterfrom
eitah:tls-client-verify-tests

Conversation

eitah commented Oct 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: updating assertion and expect order in test-tls-client-verify.js
1d409e9 
PR-URL: nodejs#23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: updating assertion and expect order in test-tls-client-verify.js
0f17c1c 
PR-URL: nodejs#23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

BridgeAR commented Oct 15, 2018

Copy link
Copy Markdown
Member

Landed in 0f17c1c 🎉

@eitah congratulations on your commit to Node.js!

BridgeAR closed this Oct 15, 2018

eitah commented Oct 15, 2018 via email

Copy link
Copy Markdown
Author

jasnell pushed a commit that referenced this pull request Oct 17, 2018
test: updating assertion and expect order in test-tls-client-verify.js
c9afea9 
PR-URL: #23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
test: updating assertion and expect order in test-tls-client-verify.js
a214716 
PR-URL: #23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
test: updating assertion and expect order in test-tls-client-verify.js
1e8ce06 
PR-URL: #23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: updating assertion and expect order in test-tls-client-verify.js
a0d903f 
PR-URL: #23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: updating assertion and expect order in test-tls-client-verify.js
299285a 
PR-URL: #23547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL