FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add async_hooks benchmark test by peterjreynoldsii · Pull Request #23556 · nodejs/node · GitHub

/ node Public

test: add async_hooks benchmark test - #23556

Closed
peterjreynoldsii wants to merge 2 commits into
nodejs:masterfrom
peterjreynoldsii:async-hooks-benchmark-test
ConversationCommits (2)ChecksFiles changed
Closed

test: add async_hooks benchmark test#23556
peterjreynoldsii wants to merge 2 commits into
nodejs:masterfrom
peterjreynoldsii:async-hooks-benchmark-test

Conversation

peterjreynoldsii commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

Added a minimalist benchmark test for the async-hooks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test: added async-hook benchmark
e63a9cc 
Added a minimalist benchmark test for the async-hooks.
nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Oct 12, 2018
jasnell reviewed Oct 12, 2018
View reviewed changes
Comment thread lib/assert.js Outdated

jasnell Oct 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: unnecessary whitespace change here... we can fix on landing tho

test: modified benchmark-async-hooks
dbd354b 
I made some formatting changes to the file I was working on and removed some extra comments.
peterjreynoldsii force-pushed the async-hooks-benchmark-test branch from 02a5e2d to dbd354b Compare October 12, 2018 18:05
targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
gabrielschulhof approved these changes Oct 12, 2018
View reviewed changes

gabrielschulhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR changed the title Async hooks benchmark test async_hooks: add benchmark test Oct 12, 2018
BridgeAR changed the title async_hooks: add benchmark test test: add async_hooks benchmark test Oct 12, 2018
gireeshpunathil approved these changes Oct 13, 2018
View reviewed changes
Comment thread test/sequential/test-benchmark-async-hooks.js
common.skip('missing crypto');

if (!common.enoughTestMem)
common.skip('Insufficient memory for TLS benchmark test');

gireeshpunathil Oct 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/TLS/async-hook ?

BridgeAR Oct 15, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed in the landed commit.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: added async-hook benchmark
d7b0be1 
Added a minimalist benchmark test for the async-hooks.

PR-URL: nodejs#23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: added async-hook benchmark
7e2edc5 
Added a minimalist benchmark test for the async-hooks.

PR-URL: nodejs#23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BridgeAR commented Oct 15, 2018

Copy link
Copy Markdown
Member

Landed in 7e2edc5 🎉

BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
test: added async-hook benchmark
3604d78 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
test: added async-hook benchmark
fa364aa 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
test: added async-hook benchmark
abf19da 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: added async-hook benchmark
aedf971 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: added async-hook benchmark
402cb65 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
gabrielschulhof gabrielschulhof approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL