FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix order of assert arguments in vm-new-script-this-context by vp359 · Pull Request #23558 · nodejs/node · GitHub

/ node Public

test: fix order of assert arguments in vm-new-script-this-context - #23558

Closed
vp359 wants to merge 1 commit into
nodejs:masterfrom
vp359:fix-test-assert-order-vm-new-script-this-context
ConversationCommits (1)ChecksFiles changed
Closed

test: fix order of assert arguments in vm-new-script-this-context#23558
vp359 wants to merge 1 commit into
nodejs:masterfrom
vp359:fix-test-assert-order-vm-new-script-this-context

Conversation

vp359 commented Oct 12, 2018 •
edited by BridgeAR
Loading

Copy link
Copy Markdown

Fixes the order of assert.strictEqual arguments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: fix order of assert arguments in vm-new-script-this-context
a80b6e8 
Fixes the order of assert.strictEqual arguments.
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
targos removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: fix order of assert arguments in vm-new-script-this-context
bdb9db7 
Fixes the order of assert.strictEqual arguments.

PR-URL: nodejs#23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
test: fix order of assert arguments in vm-new-script-this-context
c0014d5 
Fixes the order of assert.strictEqual arguments.

PR-URL: nodejs#23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BridgeAR commented Oct 15, 2018

Copy link
Copy Markdown
Member

Landed in c0014d5 🎉

@vp359 congratulations on your first commit to Node.js!

BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
test: fix order of assert arguments in vm-new-script-this-context
4118e90 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
test: fix order of assert arguments in vm-new-script-this-context
dd04e70 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
test: fix order of assert arguments in vm-new-script-this-context
0569bfe 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: fix order of assert arguments in vm-new-script-this-context
b5f4f75 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: fix order of assert arguments in vm-new-script-this-context
fcd273e 
Fixes the order of assert.strictEqual arguments.

PR-URL: #23558
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL