FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document key encryption options by tniessen · Pull Request #23632 · nodejs/node · GitHub

/ node Public

doc: document key encryption options - #23632

Closed
tniessen wants to merge 4 commits into
nodejs:masterfrom
tniessen:doc-document-keygen-encryption
ConversationCommits (4)ChecksFiles changed
Closed

doc: document key encryption options#23632
tniessen wants to merge 4 commits into
nodejs:masterfrom
tniessen:doc-document-keygen-encryption

Conversation

tniessen commented Oct 12, 2018

Copy link
Copy Markdown
Member

There is very little documentation on the supported encryption options. This should be enough for most use cases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 12, 2018

Copy link
Copy Markdown
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1220/pipeline

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 12, 2018
mscdex reviewed Oct 13, 2018
View reviewed changes
Comment thread doc/api/crypto.md Outdated

thefourtheye commented Oct 13, 2018

Copy link
Copy Markdown
Contributor

/ping @nodejs/crypto

sam-github reviewed Oct 15, 2018
View reviewed changes
Comment thread doc/api/crypto.md Outdated
Comment thread doc/api/crypto.md Outdated

bnoordhuis commented Nov 19, 2018

Copy link
Copy Markdown
Member

@tniessen Do you plan to follow up? This looks good to go once you incorporate the review feedback.

tniessen force-pushed the doc-document-keygen-encryption branch from 061ba26 to a94f159 Compare November 19, 2018 20:24

tniessen commented Nov 25, 2018

Copy link
Copy Markdown
Member Author

@nodejs/crypto @nodejs/documentation PTAL.

mscdex reviewed Nov 26, 2018
View reviewed changes
Comment thread doc/api/crypto.md Outdated
sam-github approved these changes Nov 26, 2018
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Text is informative, and LGTM. I leave it to you to decide to address (or not) the comment on duplicate docs.

Comment thread doc/api/crypto.md Outdated
tniessen force-pushed the doc-document-keygen-encryption branch from a94f159 to 464b674 Compare January 4, 2019 14:28

tniessen commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

Thanks for reviewing and sorry about the long delay, I figured it made sense to wait until the key object API had been finalized. That also took care of the duplication you were worried about, @sam-github. I didn't change the text itself, I just moved it to keyObject.export.

Trott reviewed Jan 4, 2019
View reviewed changes
Comment thread doc/api/crypto.md Outdated
tniessen changed the title doc: document key pair generation encryption doc: document key encryption options Jan 5, 2019

tniessen commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

Landed in 345d3f3, thanks for reviewing!

tniessen closed this Jan 5, 2019
addaleax pushed a commit that referenced this pull request Jan 5, 2019
doc: document key encryption options
b9b2ba2 
PR-URL: #23632
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
doc: document key encryption options
bb4efd7 
PR-URL: nodejs#23632
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: document key encryption options
a989df7 
PR-URL: nodejs#23632
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
+2 more reviewers
mscdex mscdex left review comments
sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL