FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: migrate from process.binding('config') to getOptions() by jbucio2 · Pull Request #23684 · nodejs/node · GitHub

/ node Public

repl: migrate from process.binding('config') to getOptions() - #23684

Closed
jbucio2 wants to merge 1 commit into
nodejs:masterfrom
jbucio2:repl-migrate-to-get-options
ConversationCommits (1)ChecksFiles changed
Closed

repl: migrate from process.binding('config') to getOptions()#23684
jbucio2 wants to merge 1 commit into
nodejs:masterfrom
jbucio2:repl-migrate-to-get-options

Conversation

jbucio2 commented Oct 16, 2018

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 16, 2018
addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 16, 2018
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 16, 2018

addaleax commented Oct 16, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17900/

jbucio2 commented Oct 17, 2018

Copy link
Copy Markdown
Author

@addaleax I see there are a 2 failures in the build CI, is there something I need to do to resolve the failures? Thanks!

jasnell commented Oct 17, 2018

Copy link
Copy Markdown
Member

Those failures should be unrelated.
Going to try to run them again: https://ci.nodejs.org/job/node-test-pull-request/17927/

jbucio2 commented Oct 17, 2018

Copy link
Copy Markdown
Author

@jasnell it looks like there are two check failures node-test-commit and node-test-linux-linked-debug

addaleax commented Oct 17, 2018 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Member

… Resume build again: https://ci.nodejs.org/job/node-test-pull-request/17931/ ✔️ (green besides linux-containered)

BridgeAR commented Oct 17, 2018

Copy link
Copy Markdown
Member

Rebuild linux-containered https://ci.nodejs.org/job/node-test-commit-linux-containered/7909/

jbucio2 commented Oct 18, 2018

Copy link
Copy Markdown
Author

there still appears to be build failures on the re-run

addaleax commented Oct 21, 2018

Copy link
Copy Markdown
Member

… again: https://ci.nodejs.org/job/node-test-commit-linux-containered/7992/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 22, 2018
repl: migrate from process.binding('config') to getOptions()
f1b9546 
PR-URL: nodejs#23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Trott commented Oct 22, 2018

Copy link
Copy Markdown
Member

Landed in f1b9546.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

Trott closed this Oct 22, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
repl: migrate from process.binding('config') to getOptions()
86cf014 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
repl: migrate from process.binding('config') to getOptions()
d1c0827 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
repl: migrate from process.binding('config') to getOptions()
753eb38 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
repl: migrate from process.binding('config') to getOptions()
307b277 
PR-URL: #23684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL