FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: add SET_INTEGER_CONSTANT macro by danbev · Pull Request #23687 · nodejs/node · GitHub

/ node Public

crypto: add SET_INTEGER_CONSTANT macro - #23687

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:crypto_set_integer_macro
ConversationCommits (1)ChecksFiles changed
Closed

crypto: add SET_INTEGER_CONSTANT macro#23687
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:crypto_set_integer_macro

Conversation

danbev commented Oct 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit introduces a SET_INTEGER_CONSTANT macro to reduce some code
duplication in SecureContext::Initialize.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

crypto: add SET_INTEGER_CONSANT macro
120c51e 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

nodejs-github-bot commented Oct 16, 2018

Copy link
Copy Markdown
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1259/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 16, 2018

danbev commented Oct 16, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17888/

addaleax approved these changes Oct 16, 2018
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could also be an inline/lambda function this way :)

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 16, 2018

aduh95 commented Oct 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note: typo in the title of the PR as well as in the commit message CONSANT -> CONSTANTS

danbev changed the title crypto: add SET_INTEGER_CONSANT macro crypto: add SET_INTEGER_CONSTANT macro Oct 17, 2018

danbev commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

Note: typo in the title of the PR as well as in the commit message CONSANT -> CONSTANTS

I've updated the commit message now. Thanks!

danbev commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

Re-run of failing node-test-commit

danbev commented Oct 18, 2018

Copy link
Copy Markdown
Contributor Author

Could also be an inline/lambda function this way :)

That was my first choice but I ran into an issue with the string literal and passing it to the lambda operator function. I'll take another look at this later today and see if I can figure out some way around it .

danbev commented Oct 19, 2018

Copy link
Copy Markdown
Contributor Author

Re-run of failing node-test-commit-linux-containered

danbev commented Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 30219bf.

danbev closed this Oct 24, 2018
danbev deleted the crypto_set_integer_macro branch October 24, 2018 03:48
danbev added a commit that referenced this pull request Oct 24, 2018
crypto: add SET_INTEGER_CONSANT macro
30219bf 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Oct 24, 2018
crypto: add SET_INTEGER_CONSANT macro
141aec9 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
crypto: add SET_INTEGER_CONSANT macro
d62d666 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
crypto: add SET_INTEGER_CONSANT macro
b55b5a7 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
crypto: add SET_INTEGER_CONSANT macro
4996056 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
crypto: add SET_INTEGER_CONSANT macro
5dc2fa2 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
crypto: add SET_INTEGER_CONSANT macro
a97e79c 
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
tniessen tniessen approved these changes
+1 more reviewer
thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL