FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add note about removeListener order by jasnell · Pull Request #23762 · nodejs/node · GitHub

/ node Public

doc: add note about removeListener order - #23762

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:events-removelistener-order
ConversationCommits (1)ChecksFiles changed
Closed

doc: add note about removeListener order#23762
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:events-removelistener-order

Conversation

jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member

Fixes: #21635

Checklist

jasnell added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 19, 2018

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1300/pipeline

jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

Please 👍 to fast-track

vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
Comment thread doc/api/events.md Outdated
vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
Comment thread doc/api/events.md Outdated
vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 19, 2018
jasnell force-pushed the events-removelistener-order branch from c9cbf95 to 2f8098d Compare October 23, 2018 20:03

jasnell commented Oct 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in 2f8098d

jasnell closed this Oct 23, 2018
jasnell reopened this Oct 23, 2018

jasnell commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

Sorry... heh... mixed up the PRs lol

jasnell added a commit that referenced this pull request Oct 23, 2018
doc: add note about removeListener order
b049d55 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

Landed in b049d55

jasnell closed this Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
doc: add note about removeListener order
84fdb1c 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: add note about removeListener order
c251d40 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: add note about removeListener order
9982c09 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: add note about removeListener order
e5f75cf 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: add note about removeListener order
8990e32 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: add note about removeListener order
98fc848 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
trivikr trivikr approved these changes
+2 more reviewers
mmarchini mmarchini approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL