FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document and warn if the ICU version is too old by srl295 · Pull Request #23766 · nodejs/node · GitHub

/ node Public

doc: document and warn if the ICU version is too old - #23766

Merged
srl295 merged 0 commit into
nodejs:masterfrom
srl295:min-icu
Oct 23, 2018
ConversationCommits (0)ChecksFiles changed
Merged

doc: document and warn if the ICU version is too old#23766
srl295 merged 0 commit into
nodejs:masterfrom
srl295:min-icu

Conversation

srl295 commented Oct 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #19657

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Example:

$ ./configure --with-intl=small-icu --with-icu-source=https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download
Deleting old ICU source: deps/icu
 <https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download>
 Fetch: . 15.2MB total, 15.2MB downloaded
 Extracting tarfile: deps/icu-tmp/download
WARNING: icu4c v46.x may be too old, v57.x or later is recommended.
WARNING: warnings were emitted in the configure phase

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1303/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 19, 2018
srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Oct 19, 2018
srl295 self-assigned this Oct 19, 2018

addaleax commented Oct 20, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17999/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 20, 2018
refack reviewed Oct 20, 2018
View reviewed changes
Comment thread configure.py Outdated

refack Oct 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

may? what can happen if it is? why not go all out and error?
(escape hatch is to manually edit config.gypi)

srl295 Oct 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

probably a compile error. which they will see soon enough… ±0 on making it an error, either way.

refack Oct 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ack

refack suggested changes Oct 20, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good concept. Left two comments.

Comment thread configure.py Outdated

refack Oct 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you read this with:
https://github.com/nodejs/node/blob/bce91be01e333aa67874c89eeea419eb68dcc33a/configure.py#L1266-L1267

srl295 Oct 22, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack hm. Doesn't make sense with the format of current_ver.dep … the minimum ICU is global, doesn't need to be repeated multiple times.

srl295 Oct 22, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@refack I split the minimum version to a separate file.

refack Oct 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could change the format of tools/icu/current_ver.dep to be:

{
  "current_minimum": 57,
  "packages": [ ... current content ... ]
}

refack commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

CI (just in case you don't wanna patch this any more): https://ci.nodejs.org/job/node-test-pull-request/18060/

refack removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 23, 2018

srl295 commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

@refack how about moving the contents to the new .json file in a future PR once these land? (this and the 2 other PRs)

srl295 closed this Oct 23, 2018
srl295 merged commit d8b6a1d into nodejs:master Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
doc: document and warn if the ICU version is too old
db113a2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
srl295 mentioned this pull request Oct 24, 2018
Merged
targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document and warn if the ICU version is too old
f1c2fb3 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

This lands cleanly on 10.x, should we backport to 8.x?

codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document and warn if the ICU version is too old
feacd47 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: document and warn if the ICU version is too old
e87e9f2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes
devsnek Awaiting requested review from devsnek
+2 more reviewers
refack refack approved these changes
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

srl295

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL