FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document ACL limitation for fs.access on Windows by jasnell · Pull Request #23772 · nodejs/node · GitHub

/ node Public

doc: document ACL limitation for fs.access on Windows - #23772

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-fs-access-limitation
ConversationCommits (1)ChecksFiles changed
Closed

doc: document ACL limitation for fs.access on Windows#23772
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-fs-access-limitation

Conversation

jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member

Fixes: #19192

Checklist

jasnell added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 19, 2018

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1307/pipeline

jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

Please 👍 to fast-track

sam-github approved these changes Oct 20, 2018
View reviewed changes
Comment thread doc/api/fs.md
On Windows, access-control policies (ACLs) on a directory may limit access to
a file or directory. The `fs.access()` function, however, does not check the
ACL and therefore may report that a path is accessible even if the ACL restricts
the user from reading or writing to it.

sam-github Oct 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps add one more sentence reminding of the "not recommended" race conditions above, and how this quirk of ACLs makes it even more important to not misuse fs.access() in the ways described.

jasnell Oct 23, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can do that in a separate PR

jasnell added a commit that referenced this pull request Oct 23, 2018
doc: document ACL limitation for fs.access on Windows
6c07990 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

jasnell commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

Landed in 6c07990

jasnell closed this Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
doc: document ACL limitation for fs.access on Windows
f4c4b2b 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document ACL limitation for fs.access on Windows
7746267 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document ACL limitation for fs.access on Windows
bd0e0d2 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document ACL limitation for fs.access on Windows
0ff88a3 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document ACL limitation for fs.access on Windows
47f87c5 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: document ACL limitation for fs.access on Windows
540168c 
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed

This comment was marked as spam.

Sign in to view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+3 more reviewers
sam-github sam-github approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
bzoz bzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL