FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: use libc++ with clang on Travis by richardlau · Pull Request #23791 · nodejs/node · GitHub

/ node Public

build: use libc++ with clang on Travis - #23791

Closed
richardlau wants to merge 10 commits into
nodejs:masterfrom
richardlau:travis-compiler
Closed

build: use libc++ with clang on Travis#23791
richardlau wants to merge 10 commits into
nodejs:masterfrom
richardlau:travis-compiler

Conversation

Copy link
Copy Markdown
Member

Testing alternative fix for #23778.

Checklist

richardlau added the wip Issues and PRs that are still a work in progress. label Oct 21, 2018

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member Author

Did not appear to work 😞

richardlau closed this Oct 21, 2018
richardlau reopened this Oct 21, 2018

Copy link
Copy Markdown
Member Author

Trying more things.

refack commented Oct 21, 2018

Copy link
Copy Markdown
Contributor

Did you try upgrading stdlibc++ to 4.9?

Copy link
Copy Markdown
Member Author

@refack I'm trying to see if we can actually use clang (as we're attempting to). If we have to install packages then #23778 already covers this.

refack commented Oct 21, 2018

Copy link
Copy Markdown
Contributor

I'm trying to see if we can actually use clang (as we're attempting to). If we have to install packages then #23778 already covers this.

From #23778 (comment) it seems that it does use clang, only it links against the GCC libstdc++-4.8, which has a bug.
(Run make with V=1 to see which compiler is actually used)

refack commented Oct 21, 2018

Copy link
Copy Markdown
Contributor

There's -stdlib=libc++ that supposedly tell clang to use it's own libc++

refack commented Oct 21, 2018

Copy link
Copy Markdown
Contributor

It works!

Copy link
Copy Markdown
Member Author

It works!

😮. Going to sleep now, but next steps will be to see if all the environment variable changes were necessary. Maybe also -stdlib=libc++ should be set in CXXFLAGS instead of CXX.

richardlau changed the title build: fix compiler selection on Travis builds build: use libc++ with clang on Travis Oct 21, 2018

Copy link
Copy Markdown
Member Author

Travis overrides the CC/CXX env vars set under the env: key in the matrix:

richardlau commented Oct 24, 2018
edited
Loading

Copy link
Copy Markdown
Member Author

This PR allows Travis to build with clang without installing any other packages by making it use libc++ instead of libstdc++. Although it works I'm closing this as this is a non-standard way of building (we only normally use libc++ on macOS) and #23778 better replicates the supported toolchains (gcc 4.9.4 or later) in https://github.com/nodejs/node/blob/master/BUILDING.md#supported-toolchains.

richardlau closed this Oct 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip Issues and PRs that are still a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL