| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1320/pipeline |
Sorry, something went wrong.
|
Did not appear to work 😞 |
Sorry, something went wrong.
|
Trying more things. |
Sorry, something went wrong.
|
Did you try upgrading stdlibc++ to 4.9? |
Sorry, something went wrong.
From #23778 (comment) it seems that it does use clang, only it links against the GCC libstdc++-4.8, which has a bug. |
Sorry, something went wrong.
|
There's -stdlib=libc++ that supposedly tell clang to use it's own libc++ |
Sorry, something went wrong.
|
It works! |
Sorry, something went wrong.
😮. Going to sleep now, but next steps will be to see if all the environment variable changes were necessary. Maybe also -stdlib=libc++ should be set in CXXFLAGS instead of CXX. |
Sorry, something went wrong.
Sorry, something went wrong.
|
This PR allows Travis to build with clang without installing any other packages by making it use libc++ instead of libstdc++. Although it works I'm closing this as this is a non-standard way of building (we only normally use libc++ on macOS) and #23778 better replicates the supported toolchains (gcc 4.9.4 or later) in https://github.com/nodejs/node/blob/master/BUILDING.md#supported-toolchains. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Testing alternative fix for #23778.
Checklist