src: refactor deprecated v8::String::NewFromTwoByte call - #23803
Closed
RomainLanz wants to merge 1 commit into
Closed
src: refactor deprecated v8::String::NewFromTwoByte call#23803RomainLanz wants to merge 1 commit into
RomainLanz wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
RomainLanz
force-pushed
the
fix/node_process
branch
2 times, most recently
from
872378f to
5e5684b
Compare
October 21, 2018 14:45
refack
approved these changes
Oct 21, 2018
refack
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with nit
Sorry, something went wrong.
Comment thread
src/node_process.cc
Outdated
| using v8::Integer; | ||
| using v8::Isolate; | ||
| using v8::Local; | ||
| using v8::MaybeLocal; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Personally I wouldn't add a using just for 2 instances. In this case I would keep it explicit
Sorry, something went wrong.
refack
previously approved these changes
Oct 21, 2018
refack
reviewed
Oct 21, 2018
Comment thread
src/node_process.cc
Outdated
refack
reviewed
Oct 21, 2018
Comment thread
src/node_process.cc
Outdated
refack
approved these changes
Oct 21, 2018
Copy link
Copy Markdown
Contributor
|
@RomainLanz Thank you for the contribution, and all the follow ups 🥇 P.S. If you are having trouble doing that I could help. Also feel free to contact me if you need help in general. |
Sorry, something went wrong.
RomainLanz
force-pushed
the
fix/node_process
branch
from
d1cadd1 to
08c1065
Compare
October 21, 2018 20:35
Copy link
Copy Markdown
Contributor
Thanks! |
Sorry, something went wrong.
jasnell
approved these changes
Oct 21, 2018
addaleax
pushed a commit
that referenced
this pull request
Oct 24, 2018
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 24, 2018
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23803 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist