FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use maybe version v8::Function::Call by oyyd · Pull Request #23826 · nodejs/node · GitHub

/ node Public

src: use maybe version v8::Function::Call - #23826

Closed
oyyd wants to merge 1 commit into
nodejs:masterfrom
oyyd:deprecate-soon
ConversationCommits (1)ChecksFiles changed
Closed

src: use maybe version v8::Function::Call#23826
oyyd wants to merge 1 commit into
nodejs:masterfrom
oyyd:deprecate-soon

Conversation

oyyd commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

Refs: #23804

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 23, 2018

lundibundi commented Oct 23, 2018

Copy link
Copy Markdown
Member

Original CI: https://ci.nodejs.org/job/node-test-pull-request/18068/

known flake failed (fix #23811)

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18071/

lundibundi added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 23, 2018

refack commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18082/ ✔️

addaleax commented Oct 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in d8924a0 🎉

addaleax closed this Oct 25, 2018
addaleax pushed a commit that referenced this pull request Oct 25, 2018
src: use maybe version v8::Function::Call
d8924a0 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 26, 2018
src: use maybe version v8::Function::Call
02d83d4 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Oct 27, 2018
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
src: use maybe version v8::Function::Call
ce106df 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BethGriggs pushed a commit that referenced this pull request Oct 18, 2019
src: use maybe version v8::Function::Call
18b140a 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Oct 18, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
mmarchini mmarchini approved these changes
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL