deps: patch V8 to 7.0.276.32 - #23851
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
ofrobots
approved these changes
Oct 24, 2018
ofrobots
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Rubberstamp.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I need another approval, please. |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 27, 2018
refack
approved these changes
Oct 27, 2018
refack
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
P.S. if you rebase this, it should pass Travis. |
Sorry, something went wrong.
targos
added a commit
to targos/node
that referenced
this pull request
Oct 28, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32 PR-URL: nodejs#23851 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
added a commit
that referenced
this pull request
Oct 28, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32 PR-URL: #23851 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
added a commit
that referenced
this pull request
Nov 1, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32 PR-URL: #23851 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@7.0.276.28...7.0.276.32
@nodejs/v8-update
CI: https://ci.nodejs.org/job/node-test-pull-request/18113/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1784/