FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade to c-ares v1.15.0 by bnoordhuis · Pull Request #23854 · nodejs/node · GitHub

/ node Public

deps: upgrade to c-ares v1.15.0 - #23854

Closed
bnoordhuis wants to merge 4 commits into
nodejs:masterfrom
bnoordhuis:update-cares
ConversationCommits (4)ChecksFiles changed
Closed

deps: upgrade to c-ares v1.15.0#23854
bnoordhuis wants to merge 4 commits into
nodejs:masterfrom
bnoordhuis:update-cares

Conversation

bnoordhuis commented Oct 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

deps: remove old c-ares configure files
3339399 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.
deps: upgrade to c-ares v1.15.0
fca9536 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.
deps: c-ares float, version number patch
aaa3017 
Not yet upstream.

Refs: c-ares/c-ares#229

nodejs-github-bot commented Oct 24, 2018

Copy link
Copy Markdown
Collaborator

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1358/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Oct 24, 2018

refack commented Oct 24, 2018

Copy link
Copy Markdown
Contributor

Probably should remove:

node/deps/cares/cares.gyp

Line 38 in aaa3017

'common.gypi',

refack approved these changes Oct 24, 2018
View reviewed changes

refack left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

gyp changes LGTM
RSLGTM on c-ares bump

bnoordhuis commented Oct 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI once more: https://ci.nodejs.org/job/node-test-pull-request/18178/ (edit: green)

Previous one had a couple of (what are probably) flakes.

Trott commented Nov 6, 2018

Copy link
Copy Markdown
Member

Any reason this shouldn't land? Seems ready to go. (Should it land as one, two, or three separate commits?)

addaleax commented Nov 6, 2018

Copy link
Copy Markdown
Member

Landed in aa82a21...7b1297d

addaleax closed this Nov 6, 2018
addaleax mentioned this pull request Nov 6, 2018
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Nov 6, 2018
deps: remove old c-ares configure files
50f951c 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 6, 2018
deps: upgrade to c-ares v1.15.0
3a25b17 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 6, 2018
deps: c-ares float, version number patch
7b1297d 
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2018
deps: remove old c-ares configure files
eaea90b 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2018
deps: upgrade to c-ares v1.15.0
0766369 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2018
deps: c-ares float, version number patch
6b697d4 
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
deps: remove old c-ares configure files
a9e3de9 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
deps: upgrade to c-ares v1.15.0
becafe7 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
deps: c-ares float, version number patch
0c7f4f1 
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
deps: remove old c-ares configure files
4eaab7c 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
deps: upgrade to c-ares v1.15.0
209b1d5 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
deps: c-ares float, version number patch
d89bae8 
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
deps: remove old c-ares configure files
2e4ef5b 
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
deps: upgrade to c-ares v1.15.0
52afdae 
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
deps: c-ares float, version number patch
c8b018f 
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 6, 2018
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
4128793 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
MylesBorins pushed a commit that referenced this pull request Dec 11, 2018
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
6c6c563 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
a2fa589 
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    nodejs#23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    nodejs#23822
* Added new collaborators:
  * Peter Marshall. nodejs#24170
  * Masashi Hirano. nodejs#24136

PR-URL: nodejs#24727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL