FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick d9fbfeb from upstream V8 by kjin · Pull Request #23886 · nodejs/node · GitHub

/ node Public

deps: cherry-pick d9fbfeb from upstream V8 - #23886

Closed
kjin wants to merge 1 commit into
nodejs:masterfrom
kjin:v8-float-d9fbfeb
ConversationCommits (1)ChecksFiles changed
Closed

deps: cherry-pick d9fbfeb from upstream V8#23886
kjin wants to merge 1 commit into
nodejs:masterfrom
kjin:v8-float-d9fbfeb

Conversation

kjin commented Oct 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Original commit message:

inspector: return [[StableObjectId]] as internal property

This property might be useful for fast '===' check.

R=dgozman@chromium.org,yangguo@chromium.org

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}

This commit allows us to determine the structure of circular objects through inspector (before, there was no surefire way to know if you entered an infinite loop while recursively iterating through an object's properties, because each object returned through the inspector was given a unique, monotonically increasing ID.

Hopefully, this change can make it into v10 and v11 at the very least.

cc/ @ak239 @ofrobots

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Oct 25, 2018
richardlau reviewed Oct 26, 2018
View reviewed changes
Comment thread deps/v8/include/v8-version.h Outdated

richardlau Oct 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This doesn't look right... 7.0.276.29 is: v8/v8@7.0.276.28...7.0.276.29

Please follow https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#maintenance-process for backports. If V8 7.0 is an abandoned branch, then bump the v8_embedder_string number in common.gypi.

cc @nodejs/v8

kjin Oct 26, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, not sure why I thought this was the number to increment. I've changed it back and incremented the patch level in common.gypi.

I think @ak239 mentioned to me in the past that it would be better not to land this on V8 7.0.

kjin force-pushed the v8-float-d9fbfeb branch from 6bf7c52 to 3c1afcc Compare October 26, 2018 17:02
kjin mentioned this pull request Oct 26, 2018
Merged
3 tasks
refack approved these changes Oct 26, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

refack added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 26, 2018

refack commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

Let's see if this needs changes to node's test suite as well:
PR CI: https://ci.nodejs.org/job/node-test-pull-request/18177/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1791/

refack added the inspector Issues and PRs related to the V8 inspector protocol label Oct 26, 2018

refack commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

Fails across the board for the V8 CI, e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/1791/nodes=benchmark,v8test=v8test/testReport/junit/(root)/v8tests/inspector_runtime_stable_object_id/

Failed: v8tests.inspector/runtime/stable-object-id

Stacktrace
stdout:
Checks that protocol returns the same RemoteObjectId for the same object

Running test: testGlobal
Compare global evaluated twice: true

Running test: testObject
Compare object evaluated twice: true

Running test: testObjectInArray
Compare first and second element: true

Running test: testObjectOnPause
Compare global and this: true
Compare global and global on pause: false
Compare a and a on pause: true
Command: /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out.gn/x64.release/inspector-test /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/test/inspector/protocol-test.js /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/test/inspector/runtime/stable-object-id.js --random-seed=-1778458991 --nohard-abort

refack removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 26, 2018

kjin commented Oct 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ak239 do you know why these tests might be failing? Is there a pre-requisite change that would also need to get floated?

Trott commented Nov 6, 2018

Copy link
Copy Markdown
Member

Is work ongoing with this? (If so, it could use a rebase to get rid of the merge conflict.)

alexkozy commented Nov 6, 2018

Copy link
Copy Markdown
Member

@kjin I missed this PR, feel free to ping me using email next time.
I believe that issue here is that v8 does not contain my another patch. Feel free to remove this line from test output: Compare global and global on pause and merge this PR.

kjin commented Nov 6, 2018

Copy link
Copy Markdown
Contributor Author

@ak239 Thanks for the update! I'll go ahead and do so.

kjin force-pushed the v8-float-d9fbfeb branch 2 times, most recently from e5bb4b7 to bff312e Compare November 8, 2018 00:44

kjin commented Nov 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Trott @refack I've rebased and removed the failing test as per @ak239's instructions. Not sure if Travis CI represents the extent of CI needed but it seems like it is green.

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

Not sure if Travis CI represents the extent of CI needed but it seems like it is green.

Travis is just quick sanity, we need validation from out CI cluster:
PR CI: https://ci.nodejs.org/job/node-test-pull-request/18427/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1826/

kjin force-pushed the v8-float-d9fbfeb branch from bff312e to 95733c2 Compare November 8, 2018 22:28

kjin commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

Seems like there was a line I forgot to change. @refack, would you mind running it again? Also, do you know how I can run the V8 tests locally?

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1827/

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

Also, do you know how I can run the V8 tests locally?

If you look at the few first lines of the CI's console output
You'll see:

./configure
make -j 8 test-v8 V=1 DESTCPU=x64 ARCH=x64.release ENABLE_V8_TAP=True V8_EXTRA_TEST_OPTIONS=--progress=dots --timeout=120

Most importantly is make test-v8. Just FYI it pulls the test tooling from the V8 repo with depot_tools.

deps: cherry-pick d9fbfeb from upstream V8
215dfd7 
Original commit message:

	inspector: return [[StableObjectId]] as internal property

	This property might be useful for fast '===' check.

	R=dgozman@chromium.org,yangguo@chromium.org

	Bug: none
	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
	Reviewed-on: https://chromium-review.googlesource.com/1226411
	Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
	Reviewed-by: Yang Guo <yangguo@chromium.org>
	Reviewed-by: Jakob Gruber <jgruber@chromium.org>
	Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
	Cr-Commit-Position: refs/heads/master@{nodejs#56095}

kjin commented Nov 29, 2018

Copy link
Copy Markdown
Contributor Author

@refack @ryzokuken @jasnell I believe this is ready to be landed... (pushes have just been to upgrade the V8 embedder string in common.gypi)

kjin commented Jan 3, 2019

Copy link
Copy Markdown
Contributor Author

Seems like landing V8 7.1 on master has superseded this PR... closing.

kjin closed this Jan 3, 2019
This was referenced Jan 3, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
jasnell jasnell approved these changes
+3 more reviewers
refack refack approved these changes
alexkozy alexkozy approved these changes
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inspector Issues and PRs related to the V8 inspector protocol v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL