doc: finish cleaning up *Note* tags - #23903
Closed
lundibundi wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1378/pipeline |
Sorry, something went wrong.
richardlau
approved these changes
Oct 26, 2018
jasnell
approved these changes
Oct 26, 2018
Copy link
Copy Markdown
Contributor
|
It seems we have some more cases with *Note:* / Please note: / Also note: / just Note: variants. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@vsemozhetbyt yeah, but those are harder to remove than plain Note as IMO those usually require additional changes to persist the intent of a message. I've cleaned up a few more of them, though there is still a few left. |
Sorry, something went wrong.
vsemozhetbyt
approved these changes
Oct 26, 2018
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. Refs: nodejs#23020
lundibundi
force-pushed
the
fix-note-mentions
branch
from
3fe7250 to
1a8ea8a
Compare
October 26, 2018 21:39
Copy link
Copy Markdown
Member
Author
|
@vsemozhetbyt I've made a few more changes, so this should wait for a bit more as those reviews only account for a part of the changes. Removed 'author ready' to make sure this doesn't land without the reviews of the recent changes. New CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1383/ |
Sorry, something went wrong.
richardlau
reviewed
Oct 26, 2018
Comment thread
doc/api/assert.md
Outdated
| is little benefit by catching a rejection and then rejecting it again. Instead, | ||
| consider adding a comment next to the specific code path that should not reject | ||
| and keep error messages as expressive as possible. | ||
| Using `assert.doesNotReject()` is actually not useful because there is a little |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| Using `assert.doesNotReject()` is actually not useful because there is a little | |
| Using `assert.doesNotReject()` is actually not useful because there is little |
Sorry, something went wrong.
4 tasks
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trivikr
approved these changes
Oct 29, 2018
gdams
approved these changes
Oct 29, 2018
gdams
pushed a commit
that referenced
this pull request
Oct 29, 2018
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Previously only V8 options supported both dashes in them (making them equivalent), but now Node.js also supports both styles so the note can be removed. PR-URL: #23903 Refs: #18592 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Refs: #18592
Edit: added second commit clearing Man page
doc: remove notice of dashes in V8 options
Previously only V8 options supported both dashes in them (making them
equivalent), but now Node.js also supports both styles so the note can
be removed.