FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: make example more clarified in cluster.md by ZYSzys · Pull Request #23931 · nodejs/node · GitHub

/ node Public

doc: make example more clarified in cluster.md - #23931

Closed
ZYSzys wants to merge 3 commits into
nodejs:masterfrom
zys-contrib:cluster
ConversationCommits (3)ChecksFiles changed
Closed

doc: make example more clarified in cluster.md#23931
ZYSzys wants to merge 3 commits into
nodejs:masterfrom
zys-contrib:cluster

Conversation

ZYSzys commented Oct 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Make example explanation more clarified in cluster Event:'message'.

Refs: #23930

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Oct 28, 2018
Trott requested changes Oct 28, 2018
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Instead of adding a new sentence, clarify in the existing sentence?:

Here is a cluster that uses the message system to keep a count in the master
process of the number of HTTP requests received by the workers:

Trott commented Oct 28, 2018

Copy link
Copy Markdown
Member

Or maybe even better, split into two sentences:

Here is an example using the message system. It keeps a count in the master
process of the number of HTTP requests received by the workers:

ZYSzys commented Oct 28, 2018

Copy link
Copy Markdown
Member Author

How about now ?

Trott reviewed Oct 28, 2018
View reviewed changes
Comment thread doc/api/cluster.md Outdated
process of the number of HTTP requests received by the workers:

Note that when this example running, you need to open browser and visit `http://localhost:8000`
or open another terminal window and run `curl http://localhost:8000` to see `numReqs` increasing.

Trott Oct 28, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think the new sentence is necessary with the changes to the existing sentence.

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1400/

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2018
trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2018

trivikr commented Oct 29, 2018

Copy link
Copy Markdown
Member

Landed in 2061843

trivikr closed this Oct 29, 2018
trivikr pushed a commit that referenced this pull request Oct 29, 2018
doc: make example more clarified in cluster.md
2061843 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ZYSzys deleted the cluster branch October 29, 2018 05:35
targos pushed a commit that referenced this pull request Nov 1, 2018
doc: make example more clarified in cluster.md
64c205d 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: make example more clarified in cluster.md
c0649c8 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: make example more clarified in cluster.md
8d8ea4c 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: make example more clarified in cluster.md
27b3583 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: make example more clarified in cluster.md
0a2bc74 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: make example more clarified in cluster.md
6099f5c 
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
trivikr trivikr approved these changes
+3 more reviewers
thefourtheye thefourtheye approved these changes
hiroppy hiroppy approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL