FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: moved test instructions to BUILDING.md by trivikr · Pull Request #23949 · nodejs/node · GitHub

/ node Public

doc: moved test instructions to BUILDING.md - #23949

Closed
trivikr wants to merge 3 commits into
nodejs:masterfrom
trivikr:update-test-instructions
ConversationCommits (3)ChecksFiles changed
Closed

doc: moved test instructions to BUILDING.md#23949
trivikr wants to merge 3 commits into
nodejs:masterfrom
trivikr:update-test-instructions

Conversation

trivikr commented Oct 29, 2018

Copy link
Copy Markdown
Member

Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

Checklist

doc: moved test instructions to BUILDING.md
ed4934d 
Fixes: nodejs#23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

nodejs-github-bot commented Oct 29, 2018

Copy link
Copy Markdown
Collaborator

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1406/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 29, 2018
trivikr self-assigned this Oct 29, 2018
vsemozhetbyt reviewed Oct 29, 2018
View reviewed changes
Comment thread BUILDING.md Outdated

richardlau commented Oct 29, 2018

Copy link
Copy Markdown
Member

The coverage instructions should probably point out that it is non-Windows (AFAIK). Can be done in another PR as it wasn't in the original text.

Trott reviewed Oct 29, 2018
View reviewed changes
Comment thread BUILDING.md Outdated
vsemozhetbyt and others added 2 commits October 29, 2018 17:13
f Suggestion from @vsemozhetbyt
6edeb2a 
Co-Authored-By: trivikr <16024985+trivikr@users.noreply.github.com>
f applying suggestion from @Trott
2bdbde8

trivikr commented Oct 30, 2018

Copy link
Copy Markdown
Member Author

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1421/

trivikr commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

Landed in 8c244dd

trivikr closed this Oct 31, 2018
trivikr deleted the update-test-instructions branch October 31, 2018 06:03
trivikr added a commit to trivikr/node that referenced this pull request Oct 31, 2018
doc: moved test instructions to BUILDING.md
8c244dd 
Fixes: nodejs#23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: nodejs#23949
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 1, 2018
doc: moved test instructions to BUILDING.md
539e123 
Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: #23949
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed

MylesBorins commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

This does not land cleanly on 8.x or 10.x

As 8.x is near maintenance I'm setting as don't land, but perhaps we should backport to 10.x

trivikr commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

These test instructions are for working on NodeJS core, so it's good as long as they're in master.
They need not be back-ported.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
+4 more reviewers
vsemozhetbyt vsemozhetbyt left review comments
refack refack approved these changes
fhinkel fhinkel approved these changes
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

trivikr

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node core building instructions in one place

10 participants

Back | FazBrowse Home | New Git URL