FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

code property added for rangeError by mritunjayz · Pull Request #23968 · nodejs/node · GitHub

/ node Public

code property added for rangeError - #23968

Closed
mritunjayz wants to merge 1 commit into
nodejs:masterfrom
mritunjayz:to-do-buffer-copy
ConversationCommits (1)ChecksFiles changed
Closed

code property added for rangeError#23968
mritunjayz wants to merge 1 commit into
nodejs:masterfrom
mritunjayz:to-do-buffer-copy

Conversation

mritunjayz commented Oct 30, 2018

Copy link
Copy Markdown
Contributor
Checklist

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 30, 2018

Trott commented Oct 31, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18257/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 31, 2018
trivikr reviewed Oct 31, 2018
View reviewed changes
Comment thread test/parallel/test-buffer-copy.js Outdated

AyushG3112 commented Oct 31, 2018

Copy link
Copy Markdown
Contributor

Typo in commit message: rangrError -> RangeError

mritunjayz changed the title code property added for rangrError code property added for rangeError Oct 31, 2018

Trott commented Oct 31, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18267/

mritunjayz commented Nov 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

1 failing test ? @Trott

Trott commented Nov 2, 2018

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18286/

Trott commented Nov 2, 2018

Copy link
Copy Markdown
Member

Landed in a6e836a

Trott closed this Nov 2, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 2, 2018
test: add property for RangeError in test-buffer-copy
a6e836a 
PR-URL: nodejs#23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott commented Nov 2, 2018

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Nov 2, 2018
test: add property for RangeError in test-buffer-copy
dccf4a6 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
test: add property for RangeError in test-buffer-copy
a15de48 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
test: add property for RangeError in test-buffer-copy
ce83d60 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: add property for RangeError in test-buffer-copy
6ae07a9 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: add property for RangeError in test-buffer-copy
5177cee 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: add property for RangeError in test-buffer-copy
0ed9aaa 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
test: add property for RangeError in test-buffer-copy
1d6dd96 
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL