FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: add test for ERR_HTTP2_ORIGIN_LENGTH by trivikr · Pull Request #24014 · nodejs/node · GitHub

/ node Public

http2: add test for ERR_HTTP2_ORIGIN_LENGTH - #24014

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-origin-length
ConversationCommits (1)ChecksFiles changed
Closed

http2: add test for ERR_HTTP2_ORIGIN_LENGTH#24014
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-origin-length

Conversation

trivikr commented Nov 1, 2018

Copy link
Copy Markdown
Member

Adds test for ERR_HTTP2_ORIGIN_LENGTH
It's not covered in the latest coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Nov 1, 2018

Copy link
Copy Markdown
Collaborator

@trivikr build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1448/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 1, 2018
trivikr self-assigned this Nov 1, 2018
trivikr added the http2 Issues or PRs related to the http2 subsystem. label Nov 1, 2018

trivikr commented Nov 1, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18279/

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 1, 2018

trivikr commented Nov 3, 2018

Copy link
Copy Markdown
Member Author

Closing reason: This is a backup PR for my talk about writing unit tests at NodeConfEU
If time permits, I plan to post this code change live (in another PR) at around 11:20 UTC on Tuesday November 5th, 2018. If you're free at that time, do review it live and post some comments 😊

trivikr closed this Nov 3, 2018
trivikr deleted the test-origin-length branch August 31, 2023 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

trivikr

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL