FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,win: open shortcut folder instead of running script by refack · Pull Request #24237 · nodejs/node · GitHub

/ node Public

build,win: open shortcut folder instead of running script - #24237

Closed
refack wants to merge 6 commits into
nodejs:masterfrom
refack:change-win-installer-tools-behaviur
ConversationCommits (6)ChecksFiles changed
Closed

build,win: open shortcut folder instead of running script#24237
refack wants to merge 6 commits into
nodejs:masterfrom
refack:change-win-installer-tools-behaviur

Conversation

refack commented Nov 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

An alternative UX idea:
At the end of the installer open the created Shortcut dir, where the users can explicitly call the new Install Additional Tools for Node.js shortcut.
Refs: #22645
Fixes: #23838

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1534/pipeline

nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Nov 7, 2018

joaocgreis commented Nov 8, 2018

Copy link
Copy Markdown
Member

What is the point of this? Users already opted in by checking the checkbox, and there is plenty of opportunity to stop it before it starts the package installation.

refack commented Nov 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

What is the point of this?

Pure UX.
After talking with some users, and seeking the advice of friends that work on improving UX, this was the recommendation. The idea is that installer check boxes are ignored, and users will associate the action with the installer.
Explicitly invoking the install script will make users aware of this specific action, and associates the consequences with the script and not the installer.

Even if this doesn't solve the issue, I would strongly suggest we continue iterating on this issue.

I'm flagging this as a regression because of all the negative user feedback 🤷‍♂️

refack added the regression Issues related to regressions. label Nov 8, 2018

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/build-files @nodejs/platform-windows @nodejs/UX ;)

refack requested a review from jdalton November 8, 2018 15:26

joaocgreis commented Nov 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Good point, to make it clear that it's a different thing.

Test build: https://nodejs.org/download/test/v12.0.0-test20181108dab27c03ea/

richardlau reviewed Nov 8, 2018
View reviewed changes
Comment thread tools/msvs/msi/product.wxs Outdated
Comment thread tools/msvs/msi/product.wxs Outdated
richardlau and others added 2 commits November 8, 2018 14:27
Update tools/msvs/msi/product.wxs
5d9cd8f 
Co-Authored-By: refack <refack@gmail.com>
Update tools/msvs/msi/product.wxs
9f70c62 
Co-Authored-By: refack <refack@gmail.com>

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

The output MSI
node-v12.0.0-test20181108dab27c03ea-x64.zip

refack commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

Well it doesn't like my HTML :(

richardlau commented Nov 8, 2018

Copy link
Copy Markdown
Member

Well it doesn't like my HTML :(

Also looks to have a whitespace issue between modules, and some tools.

refack mentioned this pull request Nov 8, 2018
Closed
2 tasks

refack commented Nov 9, 2018

Copy link
Copy Markdown
Contributor Author

Ok GUI looks as expected, but I can't seem to get the folder to open...

Trott commented Nov 21, 2018

Copy link
Copy Markdown
Member

@refack Is this still being worked on?

refack added the wip Issues and PRs that are still a work in progress. label Nov 26, 2018
refack closed this Dec 21, 2018
refack deleted the change-win-installer-tools-behaviur branch December 21, 2018 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
joaocgreis Awaiting requested review from joaocgreis
tniessen Awaiting requested review from tniessen
bzoz Awaiting requested review from bzoz
jdalton Awaiting requested review from jdalton

Assignees

No one assigned

Labels

install Issues and PRs related to the installers. regression Issues related to regressions. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node v11.0 windows installation opting into chocolatey+boxstarter results in infinite reboots

5 participants

Back | FazBrowse Home | New Git URL