Add missing secureProtocol values, and some docs on protocol selection - #24386
Add missing secureProtocol values, and some docs on protocol selection#24386sam-github wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1627/pipeline |
Sorry, something went wrong.
There was a problem hiding this comment.
Maybe this?:
Enable TLSv1.0 and TLSv1.1 by default. Use only
for compatibility with old TLS clients or servers. See
[secureProtocol][] for more information.
Sorry, something went wrong.
There was a problem hiding this comment.
You removed the "in addition to TLSv1.2". Why? I guess one could argue that saying TLSv1.0 and 1.1 are enabled by default doesn't necessarily mean that ONLY TLS 1.0 and 1.1 are enabled by default, but I don't like to leave people wondering. Lets tell them exactly what will be enabled.
Sorry, something went wrong.
There was a problem hiding this comment.
I'm happy to s/This should only be used/Use for/.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
vsemozhetbyt
left a comment
There was a problem hiding this comment.
Docs LGTM.
Sorry, something went wrong.
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs).
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1.
Sorry, something went wrong.
|
@nodejs/crypto @nodejs/documentation |
Sorry, something went wrong.
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs). PR-URL: #24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1. PR-URL: #24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
|
Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
Sorry, something went wrong.
Add the two TLS protocol method functions which were missing. They seem useful, and are already documented as being supported (indirectly, our docs just point to OpenSSL's docs). PR-URL: nodejs#24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Cross-reference the secureProtocol docs and the CLI docs for --tls-v1.0 and --tls-v1.1 and describe relationship. Make clear that --tls-v1.0 enables TLSv1.0 and TLSv1.1. PR-URL: nodejs#24386 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Checklist