FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] doc: sort bottom-of-file markdown links by sam-github · Pull Request #24682 · nodejs/node · GitHub

/ node Public

[v8.x backport] doc: sort bottom-of-file markdown links - #24682

Closed
sam-github wants to merge 2 commits into
nodejs:v8.x-stagingfrom
sam-github:backport-24679-to-v8.x
Closed

[v8.x backport] doc: sort bottom-of-file markdown links#24682
sam-github wants to merge 2 commits into
nodejs:v8.x-stagingfrom
sam-github:backport-24679-to-v8.x

Conversation

Copy link
Copy Markdown
Contributor

Backport of #24679

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Copy link
Copy Markdown
Collaborator

@sam-github sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Nov 27, 2018
sam-github changed the title doc: sort bottom-of-file markdown links [v8.x backport] doc: sort bottom-of-file markdown links Nov 27, 2018

Copy link
Copy Markdown
Contributor

Does this need rebasing?

sam-github force-pushed the backport-24679-to-v8.x branch from fa6e71a to cdea42e Compare November 28, 2018 17:16

Copy link
Copy Markdown
Contributor Author

PTAL

Comment thread doc/api/cluster.md Outdated
Comment thread doc/api/tls.md Outdated

vsemozhetbyt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With 2 nits.

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor Author

@nodejs/lts can you merge this to staging before it collects more conflicts? pls.

rvagg pushed a commit that referenced this pull request Dec 1, 2018
Backport of #24679

PR-URL: #24682
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

rvagg commented Dec 1, 2018

Copy link
Copy Markdown
Member

👍 done ffe1f80

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL