doc: describe current HTTP header size limit - #24700
Closed
sam-github wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1708/pipeline |
Sorry, something went wrong.
mcollina
approved these changes
Nov 28, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693
sam-github
force-pushed
the
doc-8kb-http-header-limit
branch
from
bfb4d4a to
19cdee8
Compare
November 28, 2018 18:12
Comment thread
doc/api/errors.md
Outdated
vsemozhetbyt
approved these changes
Nov 28, 2018
Copy link
Copy Markdown
Contributor
Author
|
sorry, misunderstood format of description field |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 28, 2018
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693 PR-URL: nodejs#24700 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Dec 7, 2018
Merged
This was referenced Dec 26, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: nodejs#24693 PR-URL: nodejs#24700 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that the limit was changed from 80KB to 8KB in 1860352.
Fixes: #24693
Checklist